From: Ping-Ke Shih <pkshih@realtek.com>
To: "Georg Müller" <georgmueller@gmx.net>,
"Jes.Sorensen@gmail.com" <Jes.Sorensen@gmail.com>,
"rtl8821cerfe2@gmail.com" <rtl8821cerfe2@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v3 1/4] wifi: rtl8xxxu: move dynamic_tx_rpt_timing_counter from ra_info to priv
Date: Tue, 17 Mar 2026 02:52:52 +0000 [thread overview]
Message-ID: <44e9c61d5f5d48f7880a7d9c8f1433eb@realtek.com> (raw)
In-Reply-To: <3724d77a-8aa4-40ec-9a4a-644cb1439837@gmx.net>
Georg Müller <georgmueller@gmx.net> wrote:
> Am 16.03.26 um 07:17 schrieb Ping-Ke Shih:
> >
> > Georg Müller <georgmueller@gmx.net> wrote:
> >> dynamic_tx_rpt_timing_counter is not per mac_id, but used across all
> >> mac_ids.
> >
> > I don't know the purpose of dynamic_tx_rpt_timing_counter. Could you
> > share your study?
> >
> It is used globally (not per mac) like this in the vendor driver as well [1][2].
> Bitterblue Smith gave the hint that this should not be per macid [3], so it should
> move
> out of struct ra_info.
>
> [1]
> https://github.com/lwfinger/rtl8188eu/blob/master/hal/Hal8188ERateAdaptive.c
> #L248
> [2]
> https://github.com/lwfinger/rtl8188eu/blob/v5.2.2.4/hal8188erateadaptive.c#L
> 285
> [3]
> https://lore.kernel.org/linux-wireless/938ae608-a865-4056-06de-c230d74e1847@
> gmail.com/
>
Thanks for the info. I can't find the log internally, so let's keep it
as github does.
Ping-Ke
next prev parent reply other threads:[~2026-03-17 2:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 13:53 [RFC PATCH v3 0/4] wifi: rtl8xxxu: implement AP mode for 8188EU Georg Müller
2026-03-13 13:53 ` [RFC PATCH v3 1/4] wifi: rtl8xxxu: move dynamic_tx_rpt_timing_counter from ra_info to priv Georg Müller
2026-03-16 6:17 ` Ping-Ke Shih
2026-03-16 9:30 ` Georg Müller
2026-03-17 2:52 ` Ping-Ke Shih [this message]
2026-03-13 13:53 ` [RFC PATCH v3 2/4] wifi: rtl8xxxu: handle rate control for 8188e a per mac_id Georg Müller
2026-03-16 6:35 ` Ping-Ke Shih
2026-03-16 9:41 ` Georg Müller
2026-03-13 13:53 ` [RFC PATCH v3 3/4] wifi: rtl8xxxu: update max report mac id on station add / remove for 8188e chips Georg Müller
2026-03-16 7:07 ` Ping-Ke Shih
2026-03-13 13:53 ` [RFC PATCH v3 4/4] wifi: rtl8xxxu: Enable AP mode for RTL8188EU Georg Müller
2026-03-13 23:14 ` [RFC PATCH v3 0/4] wifi: rtl8xxxu: implement AP mode for 8188EU Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44e9c61d5f5d48f7880a7d9c8f1433eb@realtek.com \
--to=pkshih@realtek.com \
--cc=Jes.Sorensen@gmail.com \
--cc=georgmueller@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox