Re: [PATCH 4/8] mt76: mt7915: add note about TXSFM 0x2

[Ben Greear <greearb@candelatech.com>]

On 11/18/21 9:02 AM, Ryder Lee wrote:
> On Thu, 2021-11-18 at 08:45 -0800, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> This format needs a special command to enable, and is not enabled
>> by default.
>>
>> Signed-off-by: Ben Greear <greearb@candelatech.com>
>> ---
>>   drivers/net/wireless/mediatek/mt76/mt7915/mac.h | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> index 7a2c740d1464..b66e740832e4 100644
>> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.h
>> @@ -348,6 +348,9 @@ struct mt7915_tx_free {
>>   
>>   #define MT_TXS4_TIMESTAMP		GENMASK(31, 0)
>>   
>> +/* The F0 variables are for TXSFM 0x0 and 0x1.  The F1 variables
>> + * are for TXSFM 0x2 aka PPDU format.
>> + */
>>   #define MT_TXS5_F0_FINAL_MPDU		BIT(31)
>>   #define MT_TXS5_F0_QOS			BIT(30)
>>   #define MT_TXS5_F0_TX_COUNT		GENMASK(29, 25)
> 
> Now that we don't need it why should it needs a special command.

It can be hard for a new developer to the driver to understand
the firmware API, so a comment could save the next person to look
at this some time and trouble.

Thanks,
Ben

> 
> Ryder
> 


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com