Re: [PATCH] bcm43xx: Fix typo in B5PHY init specifications

[Larry Finger <larry.finger@lwfinger.net>]

John W. Linville wrote:
> On Mon, Mar 12, 2007 at 12:42:18PM -0500, Larry Finger wrote:
>> David Woodhouse wrote:
>>> On Mon, 2007-03-12 at 10:53 -0400, John W. Linville wrote:
>>>> FWIW, by inspection it looks like the mac80211-based driver is
>>>> (trying?) to implement this change.
>>>>
>>>> David, have you tried the mac80211 version?  Does it still have the
>>>> same crash?
>>> Should the one in 2.6.20-1.2982.fc7 be OK? I can try that relatively
>>> easily; anything else might need to wait till I get home.
>>>
>> I don't think it will improve anything. I don't currently have a copy of wireless-dev, but the code
>> in the mb tree is identical with that of wireless-2.6. I'm currently trying to figure out the spec
>> at http://bcm-v4.sipsolutions.net/802.11/PHY/calinit and what we need to change.
> 
> Huh?  Are you looking in drivers/net/wireless/mac80211/bcm43xx?
> It certainly seems to differ quite a bit from what is in
> drivers/net/wireless/bcm43xx (i.e. no the softmac-based version).

I was, but the conclusion is the same. The generate_xxatt_list is not relevant and only the last if
clause is important. The second argument to the second call to wireless_core_reset is just a
different way to say "non-zero".

I've been looking at the code for a while now, and I still don't see where the code doesn't match
the spec. Either it is a subtle point, or I'm not even close to sharp today.

Larry