From: Andy Green <andy@warmcat.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: Monitor mode radiotap-based packet injection
Date: Sat, 17 Mar 2007 15:35:35 +0000 [thread overview]
Message-ID: <45FC0AC7.4030504@warmcat.com> (raw)
In-Reply-To: <200703171606.58803.mb@bu3sch.de>
Michael Buesch wrote:
> On Saturday 17 March 2007 15:58, Andy Green wrote:
>> Michael Buesch wrote:
>>
>>>> +#define IEEE80211_TXCTL_INJECTED_PACKET (1<<10) /* tx into monitor IF */
>>> What is a driver supposed to do on this flag? More documentation, please.
>> Hi Michael -
>>
>> The driver doesn't have to do anything with that flag... it's a private
>> mac80211-internal flag to get the attribute that the packet was injected
>
>> If there's a simpler way I'm happy to use it.
>
> Ok, no. I'm fine with this. But please mark it as mac80211-internal
> flag, so driver authors don't waste time on thinking about wtf this is. ;)
> Either by documenting it in a comment or by doing a special define
> (two underscores or something). Or both.
Both sounds like a good idea, thanks: I will wait a bit for any more
comments and then add this to a try #3. I noticed Michael Wu set his
flag to 1<<20 and I guess he had this in mind, so I will change mine to
1<<21 to further distance it from the other flags in bits and in meaning.
-Andy
next prev parent reply other threads:[~2007-03-17 15:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-17 10:58 [PATCH 0/2] Radiotap on Monitor Mode interfaces for rx and tx andy
2007-03-17 10:58 ` [PATCH 1/2] mac80211: Add radiotap support andy
2007-03-17 10:58 ` [PATCH 2/2] mac80211: Monitor mode radiotap-based packet injection andy
2007-03-17 13:59 ` Michael Buesch
2007-03-17 14:58 ` Andy Green
2007-03-17 15:06 ` Michael Buesch
2007-03-17 15:35 ` Andy Green [this message]
2007-03-17 21:30 ` Michael Wu
2007-03-17 21:51 ` Michael Wu
2007-03-17 22:09 ` Andy Green
2007-03-17 23:20 ` Michael Wu
2007-03-17 23:26 ` Andy Green
2007-03-18 9:00 ` Andy Green
2007-03-18 10:12 ` Andy Green
2007-03-17 22:05 ` Andy Green
-- strict thread matches above, loose matches on Subject: below --
2007-03-18 10:15 [PATCH 0/2] Try #3 Radiotap on Monitor Mode interfaces for rx and tx andy
2007-03-18 10:15 ` [PATCH 2/2] mac80211: Monitor mode radiotap-based packet injection andy
2007-03-19 5:55 ` Michael Wu
2007-03-19 10:54 ` Andy Green
2007-03-19 16:50 ` Michael Wu
2007-03-21 4:12 ` Joerg Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FC0AC7.4030504@warmcat.com \
--to=andy@warmcat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).