From: Andy Green <andy@warmcat.com>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] mac80211: Add radiotap support
Date: Tue, 20 Mar 2007 10:16:31 +0000 [thread overview]
Message-ID: <45FFB47F.2060807@warmcat.com> (raw)
In-Reply-To: <200703191315.33695.flamingice@sourmilk.net>
Michael Wu wrote:
Hi Michael -
> + rthdr->hdr.it_present =
> + cpu_to_le32((1 << IEEE80211_RADIOTAP_FLAGS) ||
> + (1 << IEEE80211_RADIOTAP_RATE) ||
> + (1 << IEEE80211_RADIOTAP_CHANNEL) ||
> + (1 << IEEE80211_RADIOTAP_DB_ANTSIGNAL));
These were the wrong kind of OR operator as well.
test.c:
#include <stdio.h>
int main() { printf("%d %d\n", 1 || 2, 1 | 2); return 0; }
$ gcc test.c
$ ./a.out
1 3
After fixing that it now works with tcpdump!
# tcpdump -i mon0 -s0 -X ether host 13:22:33:44:55:66
09:54:58.579725 1.0 Mb/s 2417 MHz (0x0480) 100dB signal
13:22:33:44:55:66 (oui Unknown) Unknown SSAP 0x60 > 13:22:33:44:55:66
(oui Unknown) Unknown DSAP 0x50 Unnumbered, ua, Flags [Command], length 38
0x0000: 5061 636b 6574 7370 616d 6d65 7220 6272 Packetspammer.br
0x0010: 6f61 6463 6173 7420 7061 636b 6574 2031 oadcast.packet.1
0x0020: 3639 72b1 0066 69r..f
09:54:58.679197 54.0 Mb/s 2417 MHz (0x0480) 100dB signal
13:22:33:44:55:66 (oui Unknown) Unknown SSAP 0x60 > 13:22:33:44:55:66
(oui Unknown) Unknown DSAP 0x50 Unnumbered, ua, Flags [Command], length 38
0x0000: 5061 636b 6574 7370 616d 6d65 7220 6272 Packetspammer.br
0x0010: 6f61 6463 6173 7420 7061 636b 6574 2031 oadcast.packet.1
0x0020: 3730 c01d 92cd 70....
Note the CRC appears, I guess it's okay. With zd1211rw-mac80211 as it
is, rx strength always appears as 100dB: it comes from
ieee80211_rx_status.ssi. 1Mbps injection is working as well since a
couple of tries ago on my patch.
-Andy
next prev parent reply other threads:[~2007-03-20 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-19 11:01 [PATCH 0/3] Try #4: Radiotap on Monitor Mode interfaces for rx and tx andy
2007-03-19 11:01 ` [PATCH 1/3] mac80211: Add radiotap support andy
2007-03-19 17:15 ` Michael Wu
2007-03-20 10:16 ` Andy Green [this message]
2007-03-19 11:01 ` [PATCH 2/3] mac80211: Monitor mode radiotap-based packet injection andy
2007-03-19 11:01 ` [PATCH 3/3] mac80211: Monitor mode radiotap injection docs andy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FFB47F.2060807@warmcat.com \
--to=andy@warmcat.com \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).