From: Johannes Berg <johannes@sipsolutions.net>
To: Sarika Sharma <quic_sarishar@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-next v8 06/10] wifi: mac80211: add support to accumulate removed link statistics
Date: Tue, 20 May 2025 10:40:07 +0200 [thread overview]
Message-ID: <45ce63e59fbf1c49ca295f23f802c2a6eebfdfaf.camel@sipsolutions.net> (raw)
In-Reply-To: <6aca52d3-b8d1-4e71-a51c-1fb6250859c3@quicinc.com>
On Thu, 2025-05-15 at 23:17 +0530, Sarika Sharma wrote:
>
> Looks like we can flatten them. In existing code as well we have
> flattened and use, during sta_set_sinfo()
>
> "if (!(sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_PACKETS))) {
> sinfo->tx_packets = 0;
> for (ac = 0; ac < IEEE80211_NUM_ACS; ac++)
> sinfo->tx_packets +=
> sta->deflink.tx_stats.packets[ac];
> sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_PACKETS);
> } "
>
Indeed, weird, why do we even bother counting them per AC?
johannes
next prev parent reply other threads:[~2025-05-20 8:40 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 5:48 [PATCH wireless-next v8 00/10] wifi: cfg80211/mac80211: add support to handle per link statistics of multi-link station Sarika Sharma
2025-05-15 5:48 ` [PATCH wireless-next v8 01/10] wifi: mac80211: add support towards MLO handling of station statistics Sarika Sharma
2025-05-15 5:48 ` [PATCH wireless-next v8 02/10] wifi: cfg80211: add link_station_info structure to support MLO statistics Sarika Sharma
2025-05-15 11:21 ` Johannes Berg
2025-05-15 16:40 ` Sarika Sharma
2025-05-15 11:26 ` Johannes Berg
2025-05-15 16:44 ` Sarika Sharma
2025-05-15 5:48 ` [PATCH wireless-next v8 03/10] wifi: cfg80211: extend to embed link level statistics in NL message Sarika Sharma
2025-05-15 11:25 ` Johannes Berg
2025-05-15 16:41 ` Sarika Sharma
2025-05-15 11:34 ` Johannes Berg
2025-05-15 16:58 ` Sarika Sharma
2025-05-20 8:36 ` Johannes Berg
2025-05-15 5:48 ` [PATCH wireless-next v8 04/10] wifi: cfg80211: add statistics for providing overview for MLO station Sarika Sharma
2025-05-15 11:35 ` Johannes Berg
2025-05-15 16:59 ` Sarika Sharma
2025-05-15 5:48 ` [PATCH wireless-next v8 05/10] wifi: cfg80211: allocate memory for link_station info structure Sarika Sharma
2025-05-15 11:28 ` Johannes Berg
2025-05-15 17:03 ` Sarika Sharma
2025-05-15 5:49 ` [PATCH wireless-next v8 06/10] wifi: mac80211: add support to accumulate removed link statistics Sarika Sharma
2025-05-15 11:30 ` Johannes Berg
2025-05-15 17:35 ` Sarika Sharma
2025-05-15 17:38 ` Ben Greear
2025-05-15 17:50 ` Sarika Sharma
2025-05-20 8:38 ` Johannes Berg
2025-05-20 9:34 ` Sarika Sharma
2025-05-15 11:41 ` Johannes Berg
2025-05-15 17:47 ` Sarika Sharma
2025-05-20 8:40 ` Johannes Berg [this message]
2025-05-22 4:43 ` Sarika Sharma
2025-05-22 5:03 ` Johannes Berg
2025-05-22 5:50 ` Sarika Sharma
2025-05-22 5:51 ` Johannes Berg
2025-05-22 5:54 ` Sarika Sharma
2025-05-15 5:49 ` [PATCH wireless-next v8 07/10] wifi: cfg80211: reset sinfo->filled for MLO station statistics Sarika Sharma
2025-05-15 11:36 ` Johannes Berg
2025-05-15 17:39 ` Sarika Sharma
2025-05-18 16:34 ` Sarika Sharma
2025-05-20 8:42 ` Johannes Berg
2025-05-20 9:34 ` Sarika Sharma
2025-05-15 5:49 ` [PATCH wireless-next v8 08/10] wifi: mac80211: extend support to fill link level sinfo structure Sarika Sharma
2025-05-15 11:41 ` Johannes Berg
2025-05-15 17:39 ` Sarika Sharma
2025-05-15 5:49 ` [PATCH wireless-next v8 09/10] wifi: mac80211: add link_sta_statistics ops to fill link station statistics Sarika Sharma
2025-05-15 11:38 ` Johannes Berg
2025-05-15 17:40 ` Sarika Sharma
2025-05-15 5:49 ` [PATCH wireless-next v8 10/10] wifi: mac80211: correct RX stats packet increment for multi-link Sarika Sharma
2025-05-15 11:19 ` [PATCH wireless-next v8 00/10] wifi: cfg80211/mac80211: add support to handle per link statistics of multi-link station Johannes Berg
2025-05-15 16:27 ` Sarika Sharma
2025-05-15 16:40 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ce63e59fbf1c49ca295f23f802c2a6eebfdfaf.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_sarishar@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox