Re: [PATCH] bcm43xx: Fix machine check on PPC for version 1 PHY

[Larry Finger <larry.finger@lwfinger.net>]

Michael Buesch wrote:
> On Sunday 25 March 2007 15:45, Larry Finger wrote:
>> From: David Woodhouse <dwmw2@infradead.org>
>>
>> Recent changes in the specs that were introduced in commit 
>> 740ac4fb08866d702be90f167665d03759bd27d0 were incorrect and resulted in machine check
>> errors on the PPC architecture for G PHY's with a revision number equal to 1. The
>> two offending changes are reverted.
> 
> I'm not sure this patch is complete.
> Joseph made changes to the specs that should fix the issue completely.
> I didn't look at the changes, yet.

Joseph has fixed the problem in initb5 (the first hunk), but the second hunk is still not in the new
specs. It was in the previous version in a slightly different form, but was found largely by trial
and error.

I would prefer that this patch go forward as is so that we don't end up with this bug in the
released version of 21.6.21. I am in the process of making the initg code match the current specs,
but that will certainly require more testing than I think we have time to complete before 2.6.21 is
released.

Larry