From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC v2 wireless-next 2/3] wifi: cfg80211: add initial UHR support
Date: Fri, 23 Jan 2026 12:00:35 -0800 [thread overview]
Message-ID: <460791be-6a4e-4098-bc74-effd31c8c593@oss.qualcomm.com> (raw)
In-Reply-To: <20251216172421.5f35a099e950.I26126bebd83c7ab17e99827489f946ceabb3521f@changeid>
On 12/16/2025 8:23 AM, Johannes Berg wrote:
> + static const u32 mcs_divisors[] = {
> + [ 0] = 102399, /* 16.666666... */
> + [ 1] = 51201, /* 8.333333... */
> + [ 2] = 34134, /* 5.555555... */
> + [ 3] = 25599, /* 4.166666... */
> + [ 4] = 17067, /* 2.777777... */
> + [ 5] = 12801, /* 2.083333... */
> + [ 6] = 11377, /* 1.851725... */
> + [ 7] = 10239, /* 1.666666... */
> + [ 8] = 8532, /* 1.388888... */
> + [ 9] = 7680, /* 1.250000... */
you probably already know this, but checkpatch doesn't like the first 10:
ERROR:SPACING: space prohibited after that open square bracket '['
> + [10] = 6828, /* 1.111111... */
> + [11] = 6144, /* 1.000000... */
> + [12] = 5690, /* 0.926106... */
> + [13] = 5120, /* 0.833333... */
> + [14] = 409600, /* 66.666666... */
> + [15] = 204800, /* 33.333333... */
> + [17] = 38400, /* 6.250180... */
> + [19] = 19200, /* 3.125090... */
> + [20] = 15360, /* 2.500000... */
> + [23] = 9600, /* 1.562545... */
(yes, I'm running your series through my automation since we are vetting our
additional UHR changes on top of yours)
/jeff
next prev parent reply other threads:[~2026-01-23 20:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-16 16:23 [RFC v2 wireless-next 0/3] wifi: add initial UHR support Johannes Berg
2025-12-16 16:23 ` [RFC v2 wireless-next 1/3] wifi: ieee80211: add some initial UHR definitions Johannes Berg
2025-12-16 16:23 ` [RFC v2 wireless-next 2/3] wifi: cfg80211: add initial UHR support Johannes Berg
2026-01-23 19:55 ` Jeff Johnson
2026-01-23 20:00 ` Jeff Johnson [this message]
2026-01-23 20:11 ` Johannes Berg
2026-01-23 21:51 ` Jeff Johnson
2025-12-16 16:23 ` [RFC v2 wireless-next 3/3] wifi: mac80211: " Johannes Berg
2026-01-23 20:12 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460791be-6a4e-4098-bc74-effd31c8c593@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox