From: Larry Finger <larry.finger@lwfinger.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: John Linville <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
Michael Buesch <mb@bu3sch.de>,
bcm43xx-dev@berlios.de, wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/4] mac80211 and drivers: Improve wireless statistics
Date: Sat, 14 Apr 2007 16:02:13 -0500 [thread overview]
Message-ID: <46214155.20106@lwfinger.net> (raw)
In-Reply-To: <1ba2fa240704141300w2ec2beabm9cd1376c1b9ef2bb@mail.gmail.com>
Tomas Winkler wrote:
> Those are really bad names.
> __signal__ is not meaning a value __signal level__ or __signal
> strength__ means value
> __level__ is too general to describes anything
> RSSI on other hand is well defined. Maybe it's too hw/vendor dependent
> to use in stack
> but at least its names says what it is.
> Quality should be a relative number depends on maxim
> I don't think this renaming make things clearer
> Tomas
Perhaps my names are bad; however, the existing system is broken. With it, passing the rssi value
and the signal strength from bcm43xx-mac80211 results the following output from iwconfig: "Link
Quality=216/146 Signal level=-197 dBm Noise level=-63 dBm". In bcm43xx-softmac, the code in the
driver is identical and results in "Link Quality=90/100 Signal level=-36 dBm Noise level=-69 dBm".
When I proposed a patch to fix mac80211, Michael Wu NACKed it and requested the name changes I
propose here. I don't care what names things get, but it needs to be fixed!
Larry
next prev parent reply other threads:[~2007-04-14 21:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-14 18:11 [PATCH 0/4] mac80211 and drivers: Improve wireless statistics Larry Finger
2007-04-14 20:00 ` Tomas Winkler
2007-04-14 21:02 ` Larry Finger [this message]
2007-04-14 21:42 ` Michael Wu
2007-04-14 23:11 ` Tomas Winkler
2007-04-19 14:34 ` Jiri Benc
2007-04-19 15:05 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46214155.20106@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@berlios.de \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).