From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: John Linville <linville@tuxdriver.com>,
Michael Buesch <mb@bu3sch.de>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] bcm43xx-mac80211: Make wireless statistics yield reasonable values
Date: Sun, 15 Apr 2007 14:47:00 -0500 [thread overview]
Message-ID: <46228134.2020300@lwfinger.net> (raw)
In-Reply-To: <200704150050.48891.flamingice@sourmilk.net>
Michael Wu wrote:
> On Sunday 15 April 2007 00:22, Larry Finger wrote:
>> - hw->max_rssi = -110;
>> - hw->max_signal = BCM43xx_RX_MAX_SSI;
>> + hw->max_signal = 100; /* This looks wrong, but is what mac80211 wants */
>> + hw->max_rssi = BCM43xx_RX_MAX_SSI;
> The number being passed into ssi is dBm, so why is the max being set to 60? It
> should be set to the minimum dBm that the device can report, like -110 as it
> was set before. Since SSI is actually being passed into signal, MAX_SSI
> should go to max_signal.
You are correct that -110 would be better than -196, which is what 60 translates to given the s8
arithmetic. Due to the internal workings of mac80211, the quantity in max_signal ends up as the
denominator in the qual report of x/y. I would sooner give the users a percentage that parts per 60.
Larry
prev parent reply other threads:[~2007-04-15 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-15 4:22 [PATCH] bcm43xx-mac80211: Make wireless statistics yield reasonable values Larry Finger
2007-04-15 4:50 ` Michael Wu
2007-04-15 19:47 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46228134.2020300@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).