linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Andreas Schwab <schwab@suse.de>,
	linux-wireless@vger.kernel.org, Bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging  conditional on IEEE80211_DEBUG_DROP
Date: Mon, 16 Apr 2007 19:24:14 -0500	[thread overview]
Message-ID: <462413AE.9020200@lwfinger.net> (raw)
In-Reply-To: <200704162237.01280.mb@bu3sch.de>

Michael Buesch wrote:
> On Monday 16 April 2007 20:50, Larry Finger wrote:
>> Andreas Schwab wrote:
>>> This is causing an undefined refrence to ieee80211_debug_level with
>>> CONFIG_IEEE80211_DEBUG=y and CONFIG_IEEE80211_CRYPT_CCMP=m and/or
>>> CONFIG_IEEE80211_CRYPT_TKIP=m.
>>>
>>> WARNING: "ieee80211_debug_level" [net/ieee80211/ieee80211_crypt_tkip.ko] undefined!
>>> WARNING: "ieee80211_debug_level" [net/ieee80211/ieee80211_crypt_ccmp.ko] undefined!
>>>
>>> Andreas.
>> The missing symbol was not exported by ieee80211_module.c. Sorry for not testing enough. The fix is 
>> as follows:
>>
>> Index: wireless-2.6/net/ieee80211/ieee80211_module.c
>> ===================================================================
>> --- wireless-2.6.orig/net/ieee80211/ieee80211_module.c
>> +++ wireless-2.6/net/ieee80211/ieee80211_module.c
>> @@ -229,6 +229,7 @@ void free_ieee80211(struct net_device *d
>>
>>   static int debug = 0;
>>   u32 ieee80211_debug_level = 0;
>> +EXPORT_SYMBOL_GPL(ieee80211_debug_level);
> 
> We don't use the _GPL suffix in mac80211.
> 

Upon inspection, neither does most of ieee80211. It is now changed.

Larry

  reply	other threads:[~2007-04-17  0:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-09 16:24 [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional on IEEE80211_DEBUG_DROP Larry Finger
2007-04-16 18:05 ` Andreas Schwab
2007-04-16 18:50   ` Larry Finger
2007-04-16 20:37     ` Michael Buesch
2007-04-17  0:24       ` Larry Finger [this message]
2007-04-17 13:12         ` John W. Linville
2007-04-17 14:25           ` Dan Williams
2007-04-17 15:21             ` John W. Linville
2007-04-17 18:49               ` Dan Williams
2007-04-17 15:41             ` [PATCH] ieee80211-crypt: Make some TKIP and CCMP error loggingconditional " Jouni Malinen
2007-04-17 20:40               ` Michael Buesch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=462413AE.9020200@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=Bcm43xx-dev@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mb@bu3sch.de \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).