* PATCH [001/001] - Remove duplicate rtnl_unlock()
@ 2007-04-20 2:29 Tim Gardner
2007-04-23 18:22 ` Jiri Benc
0 siblings, 1 reply; 2+ messages in thread
From: Tim Gardner @ 2007-04-20 2:29 UTC (permalink / raw)
To: linville; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
Remove a duplicate rtnl_unlock().
Signed-off-by: tim.gardner@ubuntu.com
---
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index b5a62b7..cf3d020 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -4816,7 +4816,6 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
rtnl_lock();
result = dev_alloc_name(local->mdev, local->mdev->name);
if (result < 0) {
- rtnl_unlock();
goto fail_dev;
}
--
Tim Gardner tim.gardner@ubuntu.com
[-- Attachment #2: duplicate_unlock.txt --]
[-- Type: text/plain, Size: 446 bytes --]
Remove a duplicate rtnl_unlock().
Signed-off-by: tim.gardner@ubuntu.com
---
diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
index b5a62b7..cf3d020 100644
--- a/net/mac80211/ieee80211.c
+++ b/net/mac80211/ieee80211.c
@@ -4816,7 +4816,6 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
rtnl_lock();
result = dev_alloc_name(local->mdev, local->mdev->name);
if (result < 0) {
- rtnl_unlock();
goto fail_dev;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: PATCH [001/001] - Remove duplicate rtnl_unlock()
2007-04-20 2:29 PATCH [001/001] - Remove duplicate rtnl_unlock() Tim Gardner
@ 2007-04-23 18:22 ` Jiri Benc
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Benc @ 2007-04-23 18:22 UTC (permalink / raw)
To: Tim Gardner; +Cc: linville, linux-wireless
On Thu, 19 Apr 2007 20:29:50 -0600, Tim Gardner wrote:
> Remove a duplicate rtnl_unlock().
>
> Signed-off-by: tim.gardner@ubuntu.com
Please use the "Name <mail>" form of the Signed-off-by line.
> diff --git a/net/mac80211/ieee80211.c b/net/mac80211/ieee80211.c
> index b5a62b7..cf3d020 100644
> --- a/net/mac80211/ieee80211.c
> +++ b/net/mac80211/ieee80211.c
> @@ -4816,7 +4816,6 @@ int ieee80211_register_hw(struct ieee80211_hw
> *hw) rtnl_lock();
> result = dev_alloc_name(local->mdev, local->mdev->name);
> if (result < 0) {
> - rtnl_unlock();
> goto fail_dev;
> }
Please remove the enclosing braces too.
Thanks,
Jiri
--
Jiri Benc
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-04-23 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-20 2:29 PATCH [001/001] - Remove duplicate rtnl_unlock() Tim Gardner
2007-04-23 18:22 ` Jiri Benc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).