mac80211-7.0.4 ieee80211_ptr trouble

mac80211-7.0.4 ieee80211_ptr trouble

[Dick]

Hi all,

I'm trying to compile compatible mac80211 modules with
linux-2.6.20-gentoo-r6 but I'm missing the ieee80211_ptr in struct
net_device.

/var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_get_hw_features':
/var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:119: fout: 'struct net_device' has no member named 'ieee80211_ptr'
/var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_scan':
/var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:172: fout: 'struct net_device' has no member named 'ieee80211_ptr'

What am I doing wrong, what happened to ieee80211_ptr?

Thanks in advance,
Dick

Re: mac80211-7.0.4 ieee80211_ptr trouble

[John W. Linville]

On Sat, Apr 21, 2007 at 10:27:32AM +0200, Dick wrote:
> Hi all,
> 
> I'm trying to compile compatible mac80211 modules with
> linux-2.6.20-gentoo-r6 but I'm missing the ieee80211_ptr in struct
> net_device.
> 
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_get_hw_features':
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:119: fout: 'struct net_device' has no member named 'ieee80211_ptr'
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_scan':
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:172: fout: 'struct net_device' has no member named 'ieee80211_ptr'
> 
> What am I doing wrong, what happened to ieee80211_ptr?

You'll have to ask the gentoo guys...

John
-- 
John W. Linville
linville@tuxdriver.com

Re: mac80211-7.0.4 ieee80211_ptr trouble

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

On Sat, 2007-04-21 at 14:56 -0400, John W. Linville wrote:

> > /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_get_hw_features':
> > /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:119: fout: 'struct net_device' has no member named 'ieee80211_ptr'
> > /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_scan':
> > /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:172: fout: 'struct net_device' has no member named 'ieee80211_ptr'
> > 
> > What am I doing wrong, what happened to ieee80211_ptr?
> 
> You'll have to ask the gentoo guys...

Nah, he's compiling James's stuff against a kernel that doesn't have
ieee80211_ptr, afaik James used ax25_ptr for this or something... Looks
like you forgot some header file.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: mac80211-7.0.4 ieee80211_ptr trouble

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

Never ever remove a mailing list from the CC unless you have good
reasons to and or the stuff you're discussing is actually private.


> Thank you for your reactions, I can't find a header file where
> ieee80211_ptr is defined. So I figured it might be renamed or removed by
> Gentoo or linux-2.6.20.
> Either way this should be fixed in the compat version. I hope someone
> can point me in the right direction ;)

No, you misunderstood me. The compat package includes a header file that
does these defines, but apparently you're missing it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: mac80211-7.0.4 ieee80211_ptr trouble

[James Ketrenos]

Dick wrote:
> Hi all,
> 
> I'm trying to compile compatible mac80211 modules with
> linux-2.6.20-gentoo-r6 but I'm missing the ieee80211_ptr in struct
> net_device.
> 
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_get_hw_features':
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:119: fout: 'struct net_device' has no member named 'ieee80211_ptr'
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c: In functie 'ieee80211_ioctl_scan':
> /var/tmp/portage/net-wireless/mac80211-7.0.4/work/mac80211-7.0.4/compatible/net/mac80211/ieee80211_ioctl.c:172: fout: 'struct net_device' has no member named 'ieee80211_ptr'
> 
> What am I doing wrong, what happened to ieee80211_ptr?

I have pristine 2.6.20-gentoo-r6 sources here (via 'ACCEPT_KEYWORDS=~amd64 emerge -av gentoo-sources') and am not seeing the above with a manual install of mac80211-7.0.4:

% cd mac80211-7.0.4
% make KSRC=/usr/src/linux-2.6.20-gentoo-r6 clean patch_kernel
% cd /usr/src/linux-2.6.20-gentoo-r6
% make menuconfig   # turned on MAC80211
% make -j9 ; make -j9 modules

No errors during compilation.

I haven't tried using mac80211 Gentoo packages.  

Given that it works when done pristine, and that its failing with the ebuild, I'm guessing ebuild isn't quite right.  The mac80211 build generates a source image specific to your target kernel.  If the wrong target kernel is used as the source during the creation of the 'compatible' build target, the resulting build will fail.

It looks like with your system, compatible/ was built for a kernel that already has ieee80211_ptr defined in include/linux/netdevice.h.

James

Re: mac80211-7.0.4 ieee80211_ptr trouble

[Dick Marinus]

Op zaterdag 21-04-2007 om 22:23 uur [tijdzone +0200], schreef Johannes
Berg:
> No, you misunderstood me. The compat package includes a header file
that
> does these defines, but apparently you're missing it.

Ah, it seems ieee80211_ptr doesn't cause the problem, make unmodified
failed:
===
Checking kernel compatibility in:
        /lib/modules/2.6.20-gentoo-r6/source//
 * Kernel requires compatibility version:
   - Requires net_device::ieee80211_ptr compat
   - Requires class_dev -> dev API compat
   - Requires to_net_dev API compat
   - Requires device_rename compat
Building compatibility version in 'compatible/' directory:
Copying compatible/ from origin/...done
 + Applying: patches/ieee80211_ptr.patch
        Re-use ax25_ptr in net_device for ieee80211_ptr
 + Running: ieee80211_ptr.sh
        Type-cast reused void* ax25_ptr to struct wireless_dev *
 + Applying: patches/remove_debugfs.patch
        Remove DEBUGFS usage (due to class_dev breakage)
 + Applying: patches/class_dev_to_dev-wireless-ieee80211_ptr.patch
        Reverse class_dev to dev changes when ieee80211_ptr is used
 + Applying: patches/add_to_net_dev.patch
        Add to_net_dev back in (newer kernels have it in netdevice.h)
-----patch failure output-----
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Add to_net_dev back in (newer kernels have it in netdevice.h)
|--- pre/net/mac80211/ieee80211_sysfs.c 2007-04-17 15:54:31.000000000
-0700
|+++ post/net/mac80211/ieee80211_sysfs.c        2007-04-17
15:55:57.000000000 -0700
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
1 out of 1 hunk ignored

patches/add_to_net_dev.patch failed. Terminating.
If patch or script failed, check pre/ and post/ for current stage.
===
ieee80211_sysfs doesn't seem to exist in {pre,post}/net/mac80211/
neither in /usr/src/linux.

should it have been in the mac80211-7.0.4 tarball?

Thanks,

Dick

Re: mac80211-7.0.4 ieee80211_ptr trouble

[James Ketrenos]

Dick Marinus wrote:

> Ah, it seems ieee80211_ptr doesn't cause the problem, make unmodified
> failed:
...
> |--- pre/net/mac80211/ieee80211_sysfs.c 2007-04-17 15:54:31.000000000
...
> ieee80211_sysfs doesn't seem to exist in {pre,post}/net/mac80211/
> neither in /usr/src/linux.
> 
> should it have been in the mac80211-7.0.4 tarball?

I see the problem now :)

ieee80211_sysfs.c is provided as part of Yi's pending/ patch to adding the sysfs attributes for QoS, and the add_net_dev patch is built against that code.  I've checked in a new version of the mac80211 subsystem's build scripts that corrects for this behavior.  I've build tested on 2.6.20-gentoo-r6 w/ both 'make patch_kernel' and 'make patch_kernel_unmodified' (which uses the unmodified (no 'pending' sources)

You can find it as mac80211-7.0.5.tgz at http://intellinuxwireless.org/?p=mac80211&n=downloads

Thanks,
James

Re: mac80211-7.0.4 ieee80211_ptr trouble

[Dick]

Op maandag 23-04-2007 om 10:33 uur [tijdzone -0700], schreef James
Ketrenos:
> You can find it as mac80211-7.0.5.tgz at
> http://intellinuxwireless.org/?p=mac80211&n=downloads 

Thanks a lot, it now compiles fine again!

greetings,
Dick