linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Benc <jbenc@suse.cz>, Ivo Van Doorn <ivdoorn@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: d80211: How does TX flow control work?
Date: Tue, 01 May 2007 12:41:34 +0200	[thread overview]
Message-ID: <4637195E.5050907@web.de> (raw)
In-Reply-To: <460B7CAA.4020604@web.de>

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Jan Kiszka wrote:
> Johannes Berg wrote:
>>> The actual problem was meanwhile identified: shorewall happened to
>>> overwrite the queueing discipline of wmaster0 with pfifo_fast. I found
>>> the magic knob to tell shorewall to no longer do this (at least until I
>>> want to manage traffic control that way...), but I still wonder if it is
>>> an acceptable situation. Currently, the user can intentionally or
>>> accidentally screw up the stack this way.
>> I don't seem to be able to do that:
>>
>> # tc qdisc change dev wmaster0 pfifo
>> RTNETLINK answers: Invalid argument
>>
>> # tc qdisc replace dev wmaster0 pfifo
>> RTNETLINK answers: Invalid argument
>>
>> what exactly does shorewall do?
>>
> 
> Don't recall... need to re-test... lacking time. :(
> 
> Just one note: I observed this on a 2.6.19 kernel - in case there is a
> difference to the latest.
> 

Now I came across this issue once again. It is still present, I just
observed it over the latest rt2x00 tree after updating shorewall and
forgetting to fix its config.

I redirected tc to some logging filter, and this is what shorewall does
when "CLEAR_TC=Yes" is set in shorewall.conf:

...
tc qdisc del dev wmaster0 root
tc qdisc del dev wmaster0 ingress
tc qdisc del dev wlan0 root
tc qdisc del dev wlan0 ingress

HTH,
Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

  reply	other threads:[~2007-05-01 10:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <459A5945.80909@web.de>
     [not found] ` <20070103185203.2754e059@griffin.suse.cz>
     [not found]   ` <459BF179.6000906@web.de>
     [not found]     ` <20070103191853.4f440b8b@griffin.suse.cz>
     [not found]       ` <459BFB05.9040608@web.de>
     [not found]         ` <45A03825.9080807@web.de>
     [not found]           ` <45A2A728.1070404@web.de>
2007-03-27 20:58             ` d80211: How does TX flow control work? Johannes Berg
2007-03-29  8:45               ` Jan Kiszka
2007-05-01 10:41                 ` Jan Kiszka [this message]
2007-05-01 10:47                   ` Jiri Benc
2007-05-01 10:50                     ` Jan Kiszka
2007-05-01 11:04                       ` Johannes Berg
2007-05-01 13:07                         ` Jan Kiszka
2007-05-01 13:26                           ` Johannes Berg
2007-05-01 14:18                             ` Jan Kiszka
2007-05-01 15:25                               ` Jiri Benc
2007-05-01 17:01                                 ` Michael Wu
2007-05-01 18:57                                   ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4637195E.5050907@web.de \
    --to=jan.kiszka@web.de \
    --cc=ivdoorn@gmail.com \
    --cc=jbenc@suse.cz \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).