From: Patrick McHardy <kaber@trash.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jiri Benc <jbenc@suse.cz>,
Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build
Date: Wed, 02 May 2007 16:34:11 +0200 [thread overview]
Message-ID: <4638A163.8030505@trash.net> (raw)
In-Reply-To: <46389ebb.JZh37v8gJUSOn1+U%Larry.Finger@lwfinger.net>
Larry Finger wrote:
> If MAC80211 is selected in the configuration without also selecting NET_SCHED,
> there is a missing global (tcf_destroy_chain) in the build.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-dev/net/mac80211/Kconfig
> ===================================================================
> --- wireless-dev.orig/net/mac80211/Kconfig
> +++ wireless-dev/net/mac80211/Kconfig
> @@ -9,6 +9,7 @@ config MAC80211
> select WIRELESS_EXT
> select CFG80211
> select NET_SCH_FIFO
> + select NET_SCHED
That pretty much defeats the reason why CONFIG_NET_SCH_FIFO was created.
So far without CONFIG_NET_SCHED the wme scheduler didn't even register,
so it seems the proper fix is to get rid of all #ifdef CONFIG_NET_SCHED
and simply avoid building it.
next prev parent reply other threads:[~2007-05-02 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-02 14:22 [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build Larry Finger
2007-05-02 14:34 ` Patrick McHardy [this message]
2007-05-02 15:21 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4638A163.8030505@trash.net \
--to=kaber@trash.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).