* [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build
@ 2007-05-02 14:22 Larry Finger
2007-05-02 14:34 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2007-05-02 14:22 UTC (permalink / raw)
To: Jiri Benc; +Cc: Bcm43xx-dev, linux-wireless
If MAC80211 is selected in the configuration without also selecting NET_SCHED,
there is a missing global (tcf_destroy_chain) in the build.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
Index: wireless-dev/net/mac80211/Kconfig
===================================================================
--- wireless-dev.orig/net/mac80211/Kconfig
+++ wireless-dev/net/mac80211/Kconfig
@@ -9,6 +9,7 @@ config MAC80211
select WIRELESS_EXT
select CFG80211
select NET_SCH_FIFO
+ select NET_SCHED
---help---
This option enables the hardware independent IEEE 802.11
networking stack.
---
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build
2007-05-02 14:22 [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build Larry Finger
@ 2007-05-02 14:34 ` Patrick McHardy
2007-05-02 15:21 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2007-05-02 14:34 UTC (permalink / raw)
To: Larry Finger; +Cc: Jiri Benc, Bcm43xx-dev, linux-wireless
Larry Finger wrote:
> If MAC80211 is selected in the configuration without also selecting NET_SCHED,
> there is a missing global (tcf_destroy_chain) in the build.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> Index: wireless-dev/net/mac80211/Kconfig
> ===================================================================
> --- wireless-dev.orig/net/mac80211/Kconfig
> +++ wireless-dev/net/mac80211/Kconfig
> @@ -9,6 +9,7 @@ config MAC80211
> select WIRELESS_EXT
> select CFG80211
> select NET_SCH_FIFO
> + select NET_SCHED
That pretty much defeats the reason why CONFIG_NET_SCH_FIFO was created.
So far without CONFIG_NET_SCHED the wme scheduler didn't even register,
so it seems the proper fix is to get rid of all #ifdef CONFIG_NET_SCHED
and simply avoid building it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build
2007-05-02 14:34 ` Patrick McHardy
@ 2007-05-02 15:21 ` Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2007-05-02 15:21 UTC (permalink / raw)
To: Patrick McHardy; +Cc: Jiri Benc, Bcm43xx-dev, linux-wireless
Patrick McHardy wrote:
>
>
> That pretty much defeats the reason why CONFIG_NET_SCH_FIFO was created.
> So far without CONFIG_NET_SCHED the wme scheduler didn't even register,
> so it seems the proper fix is to get rid of all #ifdef CONFIG_NET_SCHED
> and simply avoid building it.
At least this "fix" lets the system build. Whomever broke it needs to do the proper fix.
Larry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-05-02 15:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-02 14:22 [PATCH] mac80211: Fix for missing global (tcf_destroy_chain) in build Larry Finger
2007-05-02 14:34 ` Patrick McHardy
2007-05-02 15:21 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).