From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Jeff Garzik <jeff@garzik.org>
Cc: Matt Mackall <mpm@selenic.com>,
"John W. Linville" <linville@tuxdriver.com>,
Dan Williams <dcbw@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-wireless@vger.kernel.org, marcelo@kvack.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re: Please pull 'libertas' branch of wireless-2.6)
Date: Wed, 09 May 2007 09:31:31 +1000 [thread overview]
Message-ID: <46410853.5000704@yahoo.com.au> (raw)
In-Reply-To: <4640E4CE.1030506@garzik.org>
Jeff Garzik wrote:
> Nick Piggin wrote:
>
>> Two things on top of a lot of people's pet peeves list are lack of
>> good review bandwidth, and poor driver code! So it is sad this was
>> merged without Christoph's comments being addressed. "it works for
>> me, we can fix it later" is probably a big reason for quality
>> problems of some parts of the kernel.
>>
>> As for Christoph's idea of perfection... it usually isn't a bad
>> thing. And he is quite reasonable if you explain your good reason
>> to disagree or do something differently. The attitude of ignoring
>> comments can be really demotivating for a reviewer.
>
>
> I guess it's a good thing that the maintainer was not ignoring the
> review comments, then...
My rant was not directed at the driver author...
--
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2007-05-08 23:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070227205649.GH5826@tuxdriver.com>
2007-02-28 1:01 ` Please pull 'libertas' branch of wireless-2.6 John W. Linville
2007-03-03 1:29 ` Jeff Garzik
2007-03-03 5:21 ` Christoph Hellwig
2007-03-04 15:36 ` Marcelo Tosatti
2007-03-05 14:08 ` Christoph Hellwig
2007-03-07 18:16 ` Marcelo Tosatti
2007-03-07 22:24 ` Christoph Hellwig
2007-03-08 2:40 ` Dan Williams
2007-03-08 8:31 ` Christoph Hellwig
2007-03-08 14:06 ` Michael Buesch
2007-05-07 10:41 ` Christoph Hellwig
2007-05-07 12:03 ` Dan Williams
2007-05-07 14:11 ` Please pull 'revert-libertas' branch of wireless-2.6 (was Re: Please pull 'libertas' branch of wireless-2.6) John W. Linville
2007-05-07 15:22 ` Jeff Garzik
2007-05-07 15:38 ` John W. Linville
2007-05-07 15:47 ` Dan Williams
2007-05-07 15:48 ` Jeff Garzik
2007-05-07 16:44 ` John W. Linville
2007-05-08 6:12 ` Matt Mackall
2007-05-08 8:28 ` Nick Piggin
2007-05-08 20:59 ` Jeff Garzik
2007-05-08 23:31 ` Nick Piggin [this message]
2007-05-08 9:47 ` Pekka Enberg
2007-05-08 20:27 ` Please pull 'revert-libertas' branch of wireless-2.6 David Miller
2007-05-08 20:55 ` Jeff Garzik
2007-05-08 21:29 ` Dan Williams
2007-05-08 22:40 ` Jeff Garzik
2007-05-08 23:41 ` Marcelo Tosatti
2007-05-09 1:27 ` Dan Williams
2007-05-09 21:25 ` Randy Dunlap
2007-05-09 21:41 ` Dan Williams
2007-05-09 21:41 ` Jeff Garzik
2007-05-10 18:35 ` Dan Williams
2007-05-09 21:46 ` Randy Dunlap
2007-05-10 16:56 ` Dan Williams
2007-05-10 20:48 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46410853.5000704@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=dcbw@redhat.com \
--cc=hch@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=marcelo@kvack.org \
--cc=mpm@selenic.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).