linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* libertas driver
@ 2007-05-11  1:14 Andrew Morton
  2007-05-11  2:25 ` Jeff Garzik
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2007-05-11  1:14 UTC (permalink / raw)
  To: linux-wireless


x86_64 build is a bit ugly.

drivers/net/wireless/libertas/tx.c: In function 'SendSinglePacket':
drivers/net/wireless/libertas/tx.c:81: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c: In function 'libertas_process_rxed_packet':
drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c:213: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c: In function 'process_rxed_802_11_packet':
drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/rx.c:367: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
drivers/net/wireless/libertas/cmd.c: In function 'libertas_queue_cmd':
drivers/net/wireless/libertas/cmd.c:950: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/cmd.c: In function 'DownloadcommandToStation':
drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/cmd.c:979: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/cmd.c: In function 'libertas_prepare_and_send_command':
drivers/net/wireless/libertas/cmd.c:1177: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/join.c: In function 'libertas_cmd_80211_ad_hoc_join':
drivers/net/wireless/libertas/join.c:789: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/scan.c: In function 'InterpretBSSDescriptionWithIE':
drivers/net/wireless/libertas/scan.c:1118: warning: format '%d' expects type 'int', but argument 3 has type 'long unsigned int'
drivers/net/wireless/libertas/scan.c: In function 'libertas_get_scan':
drivers/net/wireless/libertas/scan.c:1586: warning: format '%d' expects type 'int', but argument 5 has type 'long unsigned int'
drivers/net/wireless/libertas/debugfs.c: In function 'libertas_parse_ssid':
drivers/net/wireless/libertas/debugfs.c:279: warning: comparison of distinct pointer types lacks a cast
drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_read':
drivers/net/wireless/libertas/debugfs.c:1823: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1825: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1827: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c: In function 'wlan_debugfs_write':
drivers/net/wireless/libertas/debugfs.c:1884: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1886: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c:1888: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/debugfs.c: At top level:
drivers/net/wireless/libertas/debugfs.c:1900: warning: initialization from incompatible pointer type
drivers/net/wireless/libertas/debugfs.c: In function 'libertas_debug_init':
drivers/net/wireless/libertas/debugfs.c:1919: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_linkmode_ioctl':
drivers/net/wireless/libertas/ioctl.c:696: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_radiomode_ioctl':
drivers/net/wireless/libertas/ioctl.c:728: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_set_debugmode_ioctl':
drivers/net/wireless/libertas/ioctl.c:757: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_cleanup_ioctl':
drivers/net/wireless/libertas/ioctl.c:1779: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_fwt_time_ioctl':
drivers/net/wireless/libertas/ioctl.c:1810: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'wlan_mesh_get_ttl_ioctl':
drivers/net/wireless/libertas/ioctl.c:1839: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c: In function 'libertas_do_ioctl':
drivers/net/wireless/libertas/ioctl.c:1947: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c:2025: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c:2171: warning: cast from pointer to integer of different size
drivers/net/wireless/libertas/ioctl.c:2188: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c:2192: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/ioctl.c:2196: warning: cast to pointer from integer of different size
drivers/net/wireless/libertas/if_usb.c: In function '__if_usb_submit_rx_urb':
drivers/net/wireless/libertas/if_usb.c:393: warning: passing argument 4 of 'usb_fill_bulk_urb' makes pointer from integer without a cast


And all this annotation

/**
 *  @brief Convert mw value to dbm value
 *
 *  @param mw      the value of mw
 *  @return        the value of dbm
 */

will be converted to kerneldoc form, I trust?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: libertas driver
  2007-05-11  1:14 libertas driver Andrew Morton
@ 2007-05-11  2:25 ` Jeff Garzik
  2007-05-11  3:14   ` Dan Williams
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Garzik @ 2007-05-11  2:25 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-wireless

Andrew Morton wrote:
> x86_64 build is a bit ugly.

Not sure what happened to his mailer (patch #0 of 19 appeared), but:
http://people.redhat.com/dcbw/libertas-patches/

Patches 18 and 19 address several of these.

	Jeff



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: libertas driver
  2007-05-11  2:25 ` Jeff Garzik
@ 2007-05-11  3:14   ` Dan Williams
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Williams @ 2007-05-11  3:14 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Andrew Morton, linux-wireless

On Thu, 2007-05-10 at 22:25 -0400, Jeff Garzik wrote:
> Andrew Morton wrote:
> > x86_64 build is a bit ugly.
> 
> Not sure what happened to his mailer (patch #0 of 19 appeared), but:
> http://people.redhat.com/dcbw/libertas-patches/
> 
> Patches 18 and 19 address several of these.

16, 18, and 19 should take care of all the issues I (and Randy) found by
sparse and building on x86-64.

Thanks,
Dan



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-05-11  3:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-11  1:14 libertas driver Andrew Morton
2007-05-11  2:25 ` Jeff Garzik
2007-05-11  3:14   ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).