Re: Please pull 'libertas' branch of wireless-2.6

Re: Please pull 'libertas' branch of wireless-2.6

[John W. Linville]

Ugh...original was too big...

Patches are available here:

	http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/libertas/

Thanks,

John

On Tue, Feb 27, 2007 at 03:56:49PM -0500, John W. Linville wrote:
> Here is the libertas wireless driver for OLPC.  It has been beaten into
> shape by a couple of review rounds on netdev and is now mostly good.
> I'm sure Marcelo isn't going anywhere... :-)
> 
> This also includes a fixup patch from me to account for the recent
> netdev class_device -> device changes.  You probably want Marcelo to
> bless it before you pull into the upstream branch of netdev-2.6.
> 
> Thanks,
> 
> John
> 
> ---
> 
> The following changes since commit c8f71b01a50597e298dc3214a2f2be7b8d31170c:
>   Linus Torvalds (1):
>         Linux 2.6.21-rc1
> 
> are found in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas
> 
> John W. Linville (1):
>       libertas: fix build breakage from netdev class_device -> device
> 
> Marcelo Tosatti (1):
>       Marvell Libertas 8388 802.11b/g USB driver
> 
>  drivers/net/wireless/Kconfig               |   13 +
>  drivers/net/wireless/Makefile              |    1 +
>  drivers/net/wireless/libertas/11d.c        |  754 ++++++++
>  drivers/net/wireless/libertas/11d.h        |  105 ++
>  drivers/net/wireless/libertas/LICENSE      |   16 +
>  drivers/net/wireless/libertas/Makefile     |   21 +
>  drivers/net/wireless/libertas/README       | 1044 +++++++++++
>  drivers/net/wireless/libertas/assoc.c      |  588 ++++++
>  drivers/net/wireless/libertas/assoc.h      |   30 +
>  drivers/net/wireless/libertas/cmd.c        | 1958 ++++++++++++++++++++
>  drivers/net/wireless/libertas/cmdresp.c    | 1031 +++++++++++
>  drivers/net/wireless/libertas/debugfs.c    | 1968 ++++++++++++++++++++
>  drivers/net/wireless/libertas/debugfs.h    |    6 +
>  drivers/net/wireless/libertas/decl.h       |   83 +
>  drivers/net/wireless/libertas/defs.h       |  369 ++++
>  drivers/net/wireless/libertas/dev.h        |  403 ++++
>  drivers/net/wireless/libertas/ethtool.c    |  184 ++
>  drivers/net/wireless/libertas/fw.c         |  361 ++++
>  drivers/net/wireless/libertas/fw.h         |   13 +
>  drivers/net/wireless/libertas/host.h       |  338 ++++
>  drivers/net/wireless/libertas/hostcmd.h    |  693 +++++++
>  drivers/net/wireless/libertas/if_bootcmd.c |   38 +
>  drivers/net/wireless/libertas/if_usb.c     |  952 ++++++++++
>  drivers/net/wireless/libertas/if_usb.h     |  109 ++
>  drivers/net/wireless/libertas/ioctl.c      | 2500 +++++++++++++++++++++++++
>  drivers/net/wireless/libertas/join.c       | 1055 +++++++++++
>  drivers/net/wireless/libertas/join.h       |   64 +
>  drivers/net/wireless/libertas/main.c       | 1258 +++++++++++++
>  drivers/net/wireless/libertas/radiotap.h   |   57 +
>  drivers/net/wireless/libertas/rx.c         |  459 +++++
>  drivers/net/wireless/libertas/sbi.h        |   40 +
>  drivers/net/wireless/libertas/scan.c       | 2044 ++++++++++++++++++++
>  drivers/net/wireless/libertas/scan.h       |  216 +++
>  drivers/net/wireless/libertas/thread.h     |   52 +
>  drivers/net/wireless/libertas/tx.c         |  285 +++
>  drivers/net/wireless/libertas/types.h      |  289 +++
>  drivers/net/wireless/libertas/version.h    |    8 +
>  drivers/net/wireless/libertas/wext.c       | 2769 ++++++++++++++++++++++++++++
>  drivers/net/wireless/libertas/wext.h       |  147 ++
>  include/net/ieee80211_radiotap.h           |   31 +-
>  40 files changed, 22351 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/net/wireless/libertas/11d.c
>  create mode 100644 drivers/net/wireless/libertas/11d.h
>  create mode 100644 drivers/net/wireless/libertas/LICENSE
>  create mode 100644 drivers/net/wireless/libertas/Makefile
>  create mode 100644 drivers/net/wireless/libertas/README
>  create mode 100644 drivers/net/wireless/libertas/assoc.c
>  create mode 100644 drivers/net/wireless/libertas/assoc.h
>  create mode 100644 drivers/net/wireless/libertas/cmd.c
>  create mode 100644 drivers/net/wireless/libertas/cmdresp.c
>  create mode 100644 drivers/net/wireless/libertas/debugfs.c
>  create mode 100644 drivers/net/wireless/libertas/debugfs.h
>  create mode 100644 drivers/net/wireless/libertas/decl.h
>  create mode 100644 drivers/net/wireless/libertas/defs.h
>  create mode 100644 drivers/net/wireless/libertas/dev.h
>  create mode 100644 drivers/net/wireless/libertas/ethtool.c
>  create mode 100644 drivers/net/wireless/libertas/fw.c
>  create mode 100644 drivers/net/wireless/libertas/fw.h
>  create mode 100644 drivers/net/wireless/libertas/host.h
>  create mode 100644 drivers/net/wireless/libertas/hostcmd.h
>  create mode 100644 drivers/net/wireless/libertas/if_bootcmd.c
>  create mode 100644 drivers/net/wireless/libertas/if_usb.c
>  create mode 100644 drivers/net/wireless/libertas/if_usb.h
>  create mode 100644 drivers/net/wireless/libertas/ioctl.c
>  create mode 100644 drivers/net/wireless/libertas/join.c
>  create mode 100644 drivers/net/wireless/libertas/join.h
>  create mode 100644 drivers/net/wireless/libertas/main.c
>  create mode 100644 drivers/net/wireless/libertas/radiotap.h
>  create mode 100644 drivers/net/wireless/libertas/rx.c
>  create mode 100644 drivers/net/wireless/libertas/sbi.h
>  create mode 100644 drivers/net/wireless/libertas/scan.c
>  create mode 100644 drivers/net/wireless/libertas/scan.h
>  create mode 100644 drivers/net/wireless/libertas/thread.h
>  create mode 100644 drivers/net/wireless/libertas/tx.c
>  create mode 100644 drivers/net/wireless/libertas/types.h
>  create mode 100644 drivers/net/wireless/libertas/version.h
>  create mode 100644 drivers/net/wireless/libertas/wext.c
>  create mode 100644 drivers/net/wireless/libertas/wext.h

-- 
John W. Linville
linville@tuxdriver.com

Re: Please pull 'libertas' branch of wireless-2.6

[Jeff Garzik]

John W. Linville wrote:
> Here is the libertas wireless driver for OLPC.  It has been beaten into
> shape by a couple of review rounds on netdev and is now mostly good.
> I'm sure Marcelo isn't going anywhere... :-)
> 
> This also includes a fixup patch from me to account for the recent
> netdev class_device -> device changes.  You probably want Marcelo to
> bless it before you pull into the upstream branch of netdev-2.6.
> 
> Thanks,
> 
> John
> 
> ---
> 
> The following changes since commit c8f71b01a50597e298dc3214a2f2be7b8d31170c:
>   Linus Torvalds (1):
>         Linux 2.6.21-rc1
> 
> are found in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas
> 
> John W. Linville (1):
>       libertas: fix build breakage from netdev class_device -> device
> 
> Marcelo Tosatti (1):
>       Marvell Libertas 8388 802.11b/g USB driver
> 
>  drivers/net/wireless/Kconfig               |   13 +
>  drivers/net/wireless/Makefile              |    1 +
>  drivers/net/wireless/libertas/11d.c        |  754 ++++++++
>  drivers/net/wireless/libertas/11d.h        |  105 ++
>  drivers/net/wireless/libertas/LICENSE      |   16 +
>  drivers/net/wireless/libertas/Makefile     |   21 +
>  drivers/net/wireless/libertas/README       | 1044 +++++++++++
>  drivers/net/wireless/libertas/assoc.c      |  588 ++++++
>  drivers/net/wireless/libertas/assoc.h      |   30 +
>  drivers/net/wireless/libertas/cmd.c        | 1958 ++++++++++++++++++++
>  drivers/net/wireless/libertas/cmdresp.c    | 1031 +++++++++++
>  drivers/net/wireless/libertas/debugfs.c    | 1968 ++++++++++++++++++++
>  drivers/net/wireless/libertas/debugfs.h    |    6 +
>  drivers/net/wireless/libertas/decl.h       |   83 +
>  drivers/net/wireless/libertas/defs.h       |  369 ++++
>  drivers/net/wireless/libertas/dev.h        |  403 ++++
>  drivers/net/wireless/libertas/ethtool.c    |  184 ++
>  drivers/net/wireless/libertas/fw.c         |  361 ++++
>  drivers/net/wireless/libertas/fw.h         |   13 +
>  drivers/net/wireless/libertas/host.h       |  338 ++++
>  drivers/net/wireless/libertas/hostcmd.h    |  693 +++++++
>  drivers/net/wireless/libertas/if_bootcmd.c |   38 +
>  drivers/net/wireless/libertas/if_usb.c     |  952 ++++++++++
>  drivers/net/wireless/libertas/if_usb.h     |  109 ++
>  drivers/net/wireless/libertas/ioctl.c      | 2500 +++++++++++++++++++++++++
>  drivers/net/wireless/libertas/join.c       | 1055 +++++++++++
>  drivers/net/wireless/libertas/join.h       |   64 +
>  drivers/net/wireless/libertas/main.c       | 1258 +++++++++++++
>  drivers/net/wireless/libertas/radiotap.h   |   57 +
>  drivers/net/wireless/libertas/rx.c         |  459 +++++
>  drivers/net/wireless/libertas/sbi.h        |   40 +
>  drivers/net/wireless/libertas/scan.c       | 2044 ++++++++++++++++++++
>  drivers/net/wireless/libertas/scan.h       |  216 +++
>  drivers/net/wireless/libertas/thread.h     |   52 +
>  drivers/net/wireless/libertas/tx.c         |  285 +++
>  drivers/net/wireless/libertas/types.h      |  289 +++
>  drivers/net/wireless/libertas/version.h    |    8 +
>  drivers/net/wireless/libertas/wext.c       | 2769 ++++++++++++++++++++++++++++
>  drivers/net/wireless/libertas/wext.h       |  147 ++
>  include/net/ieee80211_radiotap.h           |   31 +-
>  40 files changed, 22351 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/net/wireless/libertas/11d.c
>  create mode 100644 drivers/net/wireless/libertas/11d.h
>  create mode 100644 drivers/net/wireless/libertas/LICENSE
>  create mode 100644 drivers/net/wireless/libertas/Makefile
>  create mode 100644 drivers/net/wireless/libertas/README
>  create mode 100644 drivers/net/wireless/libertas/assoc.c
>  create mode 100644 drivers/net/wireless/libertas/assoc.h
>  create mode 100644 drivers/net/wireless/libertas/cmd.c
>  create mode 100644 drivers/net/wireless/libertas/cmdresp.c
>  create mode 100644 drivers/net/wireless/libertas/debugfs.c
>  create mode 100644 drivers/net/wireless/libertas/debugfs.h
>  create mode 100644 drivers/net/wireless/libertas/decl.h
>  create mode 100644 drivers/net/wireless/libertas/defs.h
>  create mode 100644 drivers/net/wireless/libertas/dev.h
>  create mode 100644 drivers/net/wireless/libertas/ethtool.c
>  create mode 100644 drivers/net/wireless/libertas/fw.c
>  create mode 100644 drivers/net/wireless/libertas/fw.h
>  create mode 100644 drivers/net/wireless/libertas/host.h
>  create mode 100644 drivers/net/wireless/libertas/hostcmd.h
>  create mode 100644 drivers/net/wireless/libertas/if_bootcmd.c
>  create mode 100644 drivers/net/wireless/libertas/if_usb.c
>  create mode 100644 drivers/net/wireless/libertas/if_usb.h
>  create mode 100644 drivers/net/wireless/libertas/ioctl.c
>  create mode 100644 drivers/net/wireless/libertas/join.c
>  create mode 100644 drivers/net/wireless/libertas/join.h
>  create mode 100644 drivers/net/wireless/libertas/main.c
>  create mode 100644 drivers/net/wireless/libertas/radiotap.h
>  create mode 100644 drivers/net/wireless/libertas/rx.c
>  create mode 100644 drivers/net/wireless/libertas/sbi.h
>  create mode 100644 drivers/net/wireless/libertas/scan.c
>  create mode 100644 drivers/net/wireless/libertas/scan.h
>  create mode 100644 drivers/net/wireless/libertas/thread.h
>  create mode 100644 drivers/net/wireless/libertas/tx.c
>  create mode 100644 drivers/net/wireless/libertas/types.h
>  create mode 100644 drivers/net/wireless/libertas/version.h
>  create mode 100644 drivers/net/wireless/libertas/wext.c
>  create mode 100644 drivers/net/wireless/libertas/wext.h

pulled into #upstream

Re: Please pull 'libertas' branch of wireless-2.6

[Christoph Hellwig]

Umm, I can't remember the updated driver ever beeig posted for review.
And to be honest I'd be surprised if it's in a good shape already.

Re: Please pull 'libertas' branch of wireless-2.6

[Marcelo Tosatti]

Hi Christoph,

On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> Umm, I can't remember the updated driver ever beeig posted for review.

http://lists.openwall.net/netdev/2007/02/10/25

> And to be honest I'd be surprised if it's in a good shape already.

Constructive comments are welcome... All comments made by Arnd (which
were many!) have been addressed.

Re: Please pull 'libertas' branch of wireless-2.6

[Christoph Hellwig]

On Sun, Mar 04, 2007 at 12:36:27PM -0300, Marcelo Tosatti wrote:
> Hi Christoph,
> 
> On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> > Umm, I can't remember the updated driver ever beeig posted for review.
> 
> http://lists.openwall.net/netdev/2007/02/10/25
> 
> > And to be honest I'd be surprised if it's in a good shape already.
> 
> Constructive comments are welcome... All comments made by Arnd (which
> were many!) have been addressed.

Comments on that versions from a quick read over it:

 - the __le* annotation issue you mentioned in the mail is important.
   We definitvely don't want any new drivers without endianess annotations,
   because there are far too many endianess problems.  Even more so
   in a case of a driver like this one that's only tested on LE hardware
   and has LE device endianess.
 - things like 11d.[ch] don't have business of beeing in a driver,
   this should be somewhere in common code.
 - there shouldn't be a LICENSE file in individual driver directories,
   especially if it's just plain old GPLv2.
 - please get rid of setting -DFOO flags in the Makefile, just use
   these directly as config symbols.
 - there shouldn't be a README file in the driver directory, this
   should be in Documentation/
 - please don't use wlan_* foo types.  a) this should be structs, not
   typedefs, and b) wlan is an utterly generic name for beeing inside
   a driver.  Then again most things using this should be inside
   generic code anyway.. (and yeah, all that is because the driver
   copied braindead linux-wlan-ng code that probably needs a major
   revision anyway)
 - there seems to be lots of tabs vs spaces messups
 - please get rid of the ENTER/LEAVE macros
 - there's an awful lot of headers without clear divided responsibilities,
   there should be only a few ones left (internal interfaces and hw
   interface basically)
 - having lowercase names for lots of hw commands is a very bad idea
   for readability
 - please get rid of all your private ioctls and iwpriv stuff
   (should I add !!!! here)
 - scan.h has very strange almost docbook comments, please convert
   them to real docbook comments and actually run things through
   the tools to make sure it's right.
 - scan.h has vi indentation comment helpers that are contrary to
   linux coding style..
 - the thread.h abstractions are really useless, opencoding them
   would make the code a lot more readable.  And make people
   notice it's actually wrong:
	o the return value from kthread_run needs to be checked
	o wlan_deactivate_thread is not needed at all
	o storing and checking the pid should go away
	o there is no need for an additional waitqueue, you can
	  just use wake_up_process for kernel threads.
 - most of types.h should not be there but you should be using
   the types from include/linux/*80211*
 - version.h shouldn't exist
 - the radiotap header changes should definitively not be in
   a "add a new driver" diff

Re: Please pull 'libertas' branch of wireless-2.6

[Marcelo Tosatti]

On Mon, Mar 05, 2007 at 02:08:25PM +0000, Christoph Hellwig wrote:
> On Sun, Mar 04, 2007 at 12:36:27PM -0300, Marcelo Tosatti wrote:
> > Hi Christoph,
> > 
> > On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> > > Umm, I can't remember the updated driver ever beeig posted for review.
> > 
> > http://lists.openwall.net/netdev/2007/02/10/25
> > 
> > > And to be honest I'd be surprised if it's in a good shape already.
> > 
> > Constructive comments are welcome... All comments made by Arnd (which
> > were many!) have been addressed.
> 
> Comments on that versions from a quick read over it:
> 
>  - the __le* annotation issue you mentioned in the mail is important.
>    We definitvely don't want any new drivers without endianess annotations,
>    because there are far too many endianess problems.  Even more so
>    in a case of a driver like this one that's only tested on LE hardware
>    and has LE device endianess.
>  - things like 11d.[ch] don't have business of beeing in a driver,
>    this should be somewhere in common code.

Most wireless drivers implement 11d internally. We certainly need to
unify the management code, but thats not a merge blocker.

>  - there shouldn't be a LICENSE file in individual driver directories,
>    especially if it's just plain old GPLv2.
>  - please get rid of setting -DFOO flags in the Makefile, just use
>    these directly as config symbols.
>  - there shouldn't be a README file in the driver directory, this
>    should be in Documentation/
>  - please don't use wlan_* foo types.  a) this should be structs, not
>    typedefs, and b) wlan is an utterly generic name for beeing inside
>    a driver.  Then again most things using this should be inside
>    generic code anyway.. (and yeah, all that is because the driver
>    copied braindead linux-wlan-ng code that probably needs a major
>    revision anyway)
>  - there seems to be lots of tabs vs spaces messups
>  - please get rid of the ENTER/LEAVE macros

These are useful for debugging. We have removed most of the useless ones 
already.

>  - there's an awful lot of headers without clear divided responsibilities,
>    there should be only a few ones left (internal interfaces and hw
>    interface basically)
>  - having lowercase names for lots of hw commands is a very bad idea
>    for readability
>  - please get rid of all your private ioctls and iwpriv stuff
>    (should I add !!!! here)

Rationale being? There are a bunch of device private knobs, and iwpriv
is the interface for such configuration. (????)

>  - scan.h has very strange almost docbook comments, please convert
>    them to real docbook comments and actually run things through
>    the tools to make sure it's right.
>  - scan.h has vi indentation comment helpers that are contrary to
>    linux coding style..
>  - the thread.h abstractions are really useless, opencoding them
>    would make the code a lot more readable.  And make people
>    notice it's actually wrong:
> 	o the return value from kthread_run needs to be checked
> 	o wlan_deactivate_thread is not needed at all
> 	o storing and checking the pid should go away
> 	o there is no need for an additional waitqueue, you can
> 	  just use wake_up_process for kernel threads.
>  - most of types.h should not be there but you should be using
>    the types from include/linux/*80211*
>  - version.h shouldn't exist
>  - the radiotap header changes should definitively not be in
>    a "add a new driver" diff

Other than this your comments are OK, will address them.

Thanks!

Re: Please pull 'libertas' branch of wireless-2.6

[Christoph Hellwig]

On Wed, Mar 07, 2007 at 03:16:38PM -0300, Marcelo Tosatti wrote:
> >  - please get rid of the ENTER/LEAVE macros
> 
> These are useful for debugging. We have removed most of the useless ones 
> already.

We've refused this on a lot of drivers.  If you really need this kind
of debugging talk to acme to use a variant of ostra for this.

> >  - please get rid of all your private ioctls and iwpriv stuff
> >    (should I add !!!! here)
> 
> Rationale being? There are a bunch of device private knobs, and iwpriv
> is the interface for such configuration. (????)

If you read netdev we're very very unhappy about device specific knobs,
as they are really painful to support.  You should also look at the
cfg80211 threads on why ioctls are really bad for moving to a knew
non-wext, non-ioctl config mechanism.  And for why iwpriv is particularly
bad look about the posts about the wext compat issues.

Re: Please pull 'libertas' branch of wireless-2.6

[Dan Williams]

On Wed, 2007-03-07 at 22:24 +0000, Christoph Hellwig wrote:
> On Wed, Mar 07, 2007 at 03:16:38PM -0300, Marcelo Tosatti wrote:
> > >  - please get rid of the ENTER/LEAVE macros
> > 
> > These are useful for debugging. We have removed most of the useless ones 
> > already.
> 
> We've refused this on a lot of drivers.  If you really need this kind
> of debugging talk to acme to use a variant of ostra for this.
> 
> > >  - please get rid of all your private ioctls and iwpriv stuff
> > >    (should I add !!!! here)
> > 
> > Rationale being? There are a bunch of device private knobs, and iwpriv
> > is the interface for such configuration. (????)
> 
> If you read netdev we're very very unhappy about device specific knobs,
> as they are really painful to support.  You should also look at the
> cfg80211 threads on why ioctls are really bad for moving to a knew
> non-wext, non-ioctl config mechanism.  And for why iwpriv is particularly
> bad look about the posts about the wext compat issues.

We are unhappy with specific knobs _if_and_only_if_ they duplicate
functionality that's currently available.

That means, for example, the prism2 WPA ioctls, because WE-19 has
equivalent functionality.  Other examples include many of the madwifi
ioctls like auth_mode for which there are WEXT calls.  Others include
the ones for creating virtual STAs that are now subsumed by mac80211.

For stuff that's seriously not common among drivers, there's nothing
else that drivers can do but provide private ioctls.

Dan

Re: Please pull 'libertas' branch of wireless-2.6

[Christoph Hellwig]

On Wed, Mar 07, 2007 at 09:40:51PM -0500, Dan Williams wrote:
> That means, for example, the prism2 WPA ioctls, because WE-19 has
> equivalent functionality.  Other examples include many of the madwifi
> ioctls like auth_mode for which there are WEXT calls.  Others include
> the ones for creating virtual STAs that are now subsumed by mac80211.
> 
> For stuff that's seriously not common among drivers, there's nothing
> else that drivers can do but provide private ioctls.

No, we're more than unhappy with private knobs in general.  Each and
every of them needs an good explanation on

 a) why it's needed
 b) why you can use an existing common interface
 c) why it doesn't make sense to add a new common interface

see all the discussion on this on say netdev or linux-scsi.

Realize it, private interfaces are really bad, it means you need
special userspace for a single driver, that's exactly the thing
we try to avoid at all cost.

Re: Please pull 'libertas' branch of wireless-2.6

[Michael Buesch]

On Thursday 08 March 2007 03:40, Dan Williams wrote:
> We are unhappy with specific knobs _if_and_only_if_ they duplicate
> functionality that's currently available.
> 
> That means, for example, the prism2 WPA ioctls, because WE-19 has
> equivalent functionality.  Other examples include many of the madwifi
> ioctls like auth_mode for which there are WEXT calls.  Others include
> the ones for creating virtual STAs that are now subsumed by mac80211.
> 
> For stuff that's seriously not common among drivers, there's nothing
> else that drivers can do but provide private ioctls.

Exactly.
And, if you add some private tuning knob, you should think about,
if it doesn't really belong to a common place like cfg80211, if other
devices have similiar functionality.

If it's really private to your device, doing some private tuning knob
is perfectly fine. But maybe you should consider sysfs, configfs or something
like that, because iwpriv is going to die with WEXT.

-- 
Greetings Michael.

Please pull 'libertas' branch of wireless-2.6

[John W. Linville]

I'm not sure why I still have libertas as a separate branch, but I do.
I don't think this should cause any trouble for you, but I figured
I'd say something in case you were wondering. :-)

Anyway, this is intended for the 'upstream' branch of netdev-2.6.
You already had pulled libertas there when last I checked.

BTW, Pavel's patch is here instead of in another branch because it
depends on changes from the original libertas driver patch.

Thanks,

John

---

The following changes since commit 971a89608a33ab591c85aa00777acd9ad05f9e82:
  John W. Linville (1):
        Merge branch 'from-linus' into libertas

are found in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas

Pavel Roskin (1):
      sparse-annotate radiotap header

Tony Breeds (1):
      libertas: use standard kernel macros

 drivers/net/wireless/libertas/debugfs.c |   41 ++--------------------
 include/net/ieee80211_radiotap.h        |   57 ++++++++++++++++---------------
 2 files changed, 33 insertions(+), 65 deletions(-)

diff --git a/drivers/net/wireless/libertas/debugfs.c b/drivers/net/wireless/libertas/debugfs.c
index 3ad1e03..51dfd20 100644
--- a/drivers/net/wireless/libertas/debugfs.c
+++ b/drivers/net/wireless/libertas/debugfs.c
@@ -1772,8 +1772,8 @@ void libertas_debugfs_remove_one(wlan_private *priv)
 
 /* debug entry */
 
-#define item_size(n) (sizeof ((wlan_adapter *)0)->n)
-#define item_addr(n) ((u32) &((wlan_adapter *)0)->n)
+#define item_size(n)	(FIELD_SIZEOF(wlan_adapter, n))
+#define item_addr(n)	(offsetof(wlan_adapter, n))
 
 struct debug_data {
 	char name[32];
@@ -1789,40 +1789,7 @@ static struct debug_data items[] = {
 	{"psstate", item_size(psstate), item_addr(psstate)},
 };
 
-static int num_of_items = sizeof(items) / sizeof(items[0]);
-
-/**
- *  @brief convert string to number
- *
- *  @param s   	   pointer to numbered string
- *  @return 	   converted number from string s
- */
-static int string_to_number(char *s)
-{
-	int r = 0;
-	int base = 0;
-
-	if ((strncmp(s, "0x", 2) == 0) || (strncmp(s, "0X", 2) == 0))
-		base = 16;
-	else
-		base = 10;
-
-	if (base == 16)
-		s += 2;
-
-	for (s = s; *s != 0; s++) {
-		if ((*s >= 48) && (*s <= 57))
-			r = (r * base) + (*s - 48);
-		else if ((*s >= 65) && (*s <= 70))
-			r = (r * base) + (*s - 55);
-		else if ((*s >= 97) && (*s <= 102))
-			r = (r * base) + (*s - 87);
-		else
-			break;
-	}
-
-	return r;
-}
+static int num_of_items = ARRAY_SIZE(items);
 
 /**
  *  @brief proc read function
@@ -1912,7 +1879,7 @@ static int wlan_debugfs_write(struct file *f, const char __user *buf,
 			if (!p2)
 				break;
 			p2++;
-			r = string_to_number(p2);
+			r = simple_strtoul(p2, NULL, 0);
 			if (d[i].size == 1)
 				*((u8 *) d[i].addr) = (u8) r;
 			else if (d[i].size == 2)
diff --git a/include/net/ieee80211_radiotap.h b/include/net/ieee80211_radiotap.h
index c6e0d81..f3bc00e 100644
--- a/include/net/ieee80211_radiotap.h
+++ b/include/net/ieee80211_radiotap.h
@@ -66,7 +66,9 @@
  */
 #define IEEE80211_RADIOTAP_HDRLEN	64
 
-/* The radio capture header precedes the 802.11 header. */
+/* The radio capture header precedes the 802.11 header.
+ * All data in the header is little endian on all platforms.
+ */
 struct ieee80211_radiotap_header {
 	u8 it_version;		/* Version 0. Only increases
 				 * for drastic changes,
@@ -74,12 +76,12 @@ struct ieee80211_radiotap_header {
 				 * new fields does not count.
 				 */
 	u8 it_pad;
-	u16 it_len;		/* length of the whole
+	__le16 it_len;		/* length of the whole
 				 * header in bytes, including
 				 * it_version, it_pad,
 				 * it_len, and data fields.
 				 */
-	u32 it_present;		/* A bitmap telling which
+	__le32 it_present;	/* A bitmap telling which
 				 * fields are present. Set bit 31
 				 * (0x80000000) to extend the
 				 * bitmap by another 32 bits.
@@ -88,104 +90,103 @@ struct ieee80211_radiotap_header {
 				 */
 };
 
-/* Name                                 Data type       Units
- * ----                                 ---------       -----
+/* Name                                 Data type    Units
+ * ----                                 ---------    -----
  *
- * IEEE80211_RADIOTAP_TSFT              u64       microseconds
+ * IEEE80211_RADIOTAP_TSFT              __le64       microseconds
  *
  *      Value in microseconds of the MAC's 64-bit 802.11 Time
  *      Synchronization Function timer when the first bit of the
  *      MPDU arrived at the MAC. For received frames, only.
  *
- * IEEE80211_RADIOTAP_CHANNEL           2 x u16   MHz, bitmap
+ * IEEE80211_RADIOTAP_CHANNEL           2 x __le16   MHz, bitmap
  *
  *      Tx/Rx frequency in MHz, followed by flags (see below).
  *
- * IEEE80211_RADIOTAP_FHSS              u16       see below
+ * IEEE80211_RADIOTAP_FHSS              __le16       see below
  *
  *      For frequency-hopping radios, the hop set (first byte)
  *      and pattern (second byte).
  *
- * IEEE80211_RADIOTAP_RATE              u8        500kb/s
+ * IEEE80211_RADIOTAP_RATE              u8           500kb/s
  *
  *      Tx/Rx data rate
  *
- * IEEE80211_RADIOTAP_DBM_ANTSIGNAL     int8_t          decibels from
- *                                                      one milliwatt (dBm)
+ * IEEE80211_RADIOTAP_DBM_ANTSIGNAL     s8           decibels from
+ *                                                   one milliwatt (dBm)
  *
  *      RF signal power at the antenna, decibel difference from
  *      one milliwatt.
  *
- * IEEE80211_RADIOTAP_DBM_ANTNOISE      int8_t          decibels from
- *                                                      one milliwatt (dBm)
+ * IEEE80211_RADIOTAP_DBM_ANTNOISE      s8           decibels from
+ *                                                   one milliwatt (dBm)
  *
  *      RF noise power at the antenna, decibel difference from one
  *      milliwatt.
  *
- * IEEE80211_RADIOTAP_DB_ANTSIGNAL      u8        decibel (dB)
+ * IEEE80211_RADIOTAP_DB_ANTSIGNAL      u8           decibel (dB)
  *
  *      RF signal power at the antenna, decibel difference from an
  *      arbitrary, fixed reference.
  *
- * IEEE80211_RADIOTAP_DB_ANTNOISE       u8        decibel (dB)
+ * IEEE80211_RADIOTAP_DB_ANTNOISE       u8           decibel (dB)
  *
  *      RF noise power at the antenna, decibel difference from an
  *      arbitrary, fixed reference point.
  *
- * IEEE80211_RADIOTAP_LOCK_QUALITY      u16       unitless
+ * IEEE80211_RADIOTAP_LOCK_QUALITY      __le16       unitless
  *
  *      Quality of Barker code lock. Unitless. Monotonically
  *      nondecreasing with "better" lock strength. Called "Signal
  *      Quality" in datasheets.  (Is there a standard way to measure
  *      this?)
  *
- * IEEE80211_RADIOTAP_TX_ATTENUATION    u16       unitless
+ * IEEE80211_RADIOTAP_TX_ATTENUATION    __le16       unitless
  *
  *      Transmit power expressed as unitless distance from max
  *      power set at factory calibration.  0 is max power.
  *      Monotonically nondecreasing with lower power levels.
  *
- * IEEE80211_RADIOTAP_DB_TX_ATTENUATION u16       decibels (dB)
+ * IEEE80211_RADIOTAP_DB_TX_ATTENUATION __le16       decibels (dB)
  *
  *      Transmit power expressed as decibel distance from max power
  *      set at factory calibration.  0 is max power.  Monotonically
  *      nondecreasing with lower power levels.
  *
- * IEEE80211_RADIOTAP_DBM_TX_POWER      int8_t          decibels from
- *                                                      one milliwatt (dBm)
+ * IEEE80211_RADIOTAP_DBM_TX_POWER      s8           decibels from
+ *                                                   one milliwatt (dBm)
  *
  *      Transmit power expressed as dBm (decibels from a 1 milliwatt
  *      reference). This is the absolute power level measured at
  *      the antenna port.
  *
- * IEEE80211_RADIOTAP_FLAGS             u8        bitmap
+ * IEEE80211_RADIOTAP_FLAGS             u8           bitmap
  *
  *      Properties of transmitted and received frames. See flags
  *      defined below.
  *
- * IEEE80211_RADIOTAP_ANTENNA           u8        antenna index
+ * IEEE80211_RADIOTAP_ANTENNA           u8           antenna index
  *
  *      Unitless indication of the Rx/Tx antenna for this packet.
  *      The first antenna is antenna 0.
  *
- * IEEE80211_RADIOTAP_RX_FLAGS          u_int16_t       bitmap
+ * IEEE80211_RADIOTAP_RX_FLAGS          __le16       bitmap
  *
  *     Properties of received frames. See flags defined below.
  *
- * IEEE80211_RADIOTAP_TX_FLAGS          u_int16_t       bitmap
+ * IEEE80211_RADIOTAP_TX_FLAGS          __le16       bitmap
  *
  *     Properties of transmitted frames. See flags defined below.
  *
- * IEEE80211_RADIOTAP_RTS_RETRIES       u_int8_t        data
+ * IEEE80211_RADIOTAP_RTS_RETRIES       u8           data
  *
  *     Number of rts retries a transmitted frame used.
  *
- * IEEE80211_RADIOTAP_DATA_RETRIES      u_int8_t        data
+ * IEEE80211_RADIOTAP_DATA_RETRIES      u8           data
  *
  *     Number of unicast retries a transmitted frame used.
  *
- *
- * IEEE80211_RADIOTAP_FCS           	u32       data
+ * IEEE80211_RADIOTAP_FCS           	__le32       data
  *
  *	FCS from frame in network byte order.
  */
-- 
John W. Linville
linville@tuxdriver.com

Re: Please pull 'libertas' branch of wireless-2.6

[Christoph Hellwig]

On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> Umm, I can't remember the updated driver ever beeig posted for review.
> And to be honest I'd be surprised if it's in a good shape already.

Of course it's not anywhere near good shape.  Almost all items from my
review were completely ignored, and we have another totoally substandard
wireless driver with crappy thread handling, a huge number of broken private
ioctls and partially absymal codingstyle.

And I didn't even get a reply to my mail addressing the concerns above.

Re: Please pull 'libertas' branch of wireless-2.6

[Dan Williams]

On Mon, 2007-05-07 at 11:41 +0100, Christoph Hellwig wrote:
> On Sat, Mar 03, 2007 at 05:21:40AM +0000, Christoph Hellwig wrote:
> > Umm, I can't remember the updated driver ever beeig posted for review.
> > And to be honest I'd be surprised if it's in a good shape already.
> 
> Of course it's not anywhere near good shape.  Almost all items from my
> review were completely ignored, and we have another totoally substandard
> wireless driver with crappy thread handling, a huge number of broken private
> ioctls and partially absymal codingstyle.

 - things like 11d.[ch] don't have business of being in a driver,
   this should be somewhere in common code.

There is no common code for this.  mac80211 will eventually grow a
utility library that libertas will hopefully be able to attach to.

 - please get rid of the ENTER/LEAVE macros

People have said that many drivers do this, and it's quite useful for
debugging.

 - please get rid of all your private ioctls and iwpriv stuff
   (should I add !!!! here)

Any ioctls that have equivalents in WEXT or ethtool can certainly be
removed.  Mesh ones like fwt_reset, bt_reset, mesh_get_ttl, etc have no
current equivalents and will need to stick around.  I've already removed
all the ones that were relevant for WPA and moved them to standard WEXT
calls.

 - most of types.h should not be there but you should be using
   the types from include/linux/*80211*

I've already updated libertas-2.6 git with a ton of updates for this.

In any case, lets push off any merge until 2.6.23 so the rest of the
comments can be dealt with:

 - the __le* annotation issue you mentioned in the mail is important.
 - there shouldn't be a LICENSE file in individual driver directories,
   especially if it's just plain old GPLv2.
 - please get rid of setting -DFOO flags in the Makefile, just use
   these directly as config symbols.
 - there shouldn't be a README file in the driver directory, this
   should be in Documentation/
 - please don't use wlan_* foo types.  a) this should be structs, not
   typedefs, and b) wlan is an utterly generic name for beeing inside
   a driver.
 - there seems to be lots of tabs vs spaces messups
 - there's an awful lot of headers without clear divided
responsibilities,
   there should be only a few ones left (internal interfaces and hw
   interface basically)
 - having lowercase names for lots of hw commands is a very bad idea
   for readability
 - etc

Dan

> And I didn't even get a reply to my mail addressing the concerns above.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Please pull 'libertas' branch of wireless-2.6

[John W. Linville]

[-- Attachment #1: Type: text/plain, Size: 2536 bytes --]

The following changes since commit 1f8a6b658a943b4f04a1fc7b3a420360202c86cd:
  Linus Torvalds (1):
        Merge git://git.kernel.org/.../bunk/trivial

are found in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas

Dan Williams (19):
      libertas: remove WPA_SUPPLICANT structure
      libertas: use <net/ieee80211.h> for MAX_WPA_IE_LEN
      libertas: fix size of SSID comparison in stop_adhoc check
      libertas: remove 8021xauthalgs private ioctl
      libertas: remove setauthalg private ioctl
      libertas: remove incorrect vi modelines
      libertas: remove custom encryption mode stuff
      libertas: remove setwpaie private ioctl
      libertas: remove WLAN_802_11_AUTHENTICATION_MODE
      libertas: remove WLAN_802_11_WEP_STATUS enum
      libertas: remove WLAN_802_11_NETWORK_INFRASTRUCTURE enum
      libertas: Get rid of version.h
      libertas: Purge non-mesh ioctls
      libertas: remove SUPPORT_BOOT_COMMAND
      libertas: Clean up debug defines
      libertas: make debugfs.c sparse-clean
      libertas: fix missing unlock in TX error path
      libertas: sparse fixes
      libertas: 64-bit cleanups

 drivers/net/wireless/libertas/Makefile  |    9 -
 drivers/net/wireless/libertas/README    |  516 -----------
 drivers/net/wireless/libertas/assoc.c   |   41 +-
 drivers/net/wireless/libertas/cmd.c     |   23 +-
 drivers/net/wireless/libertas/cmdresp.c |    4 +-
 drivers/net/wireless/libertas/debugfs.c |   31 +-
 drivers/net/wireless/libertas/defs.h    |   52 +-
 drivers/net/wireless/libertas/dev.h     |   14 +-
 drivers/net/wireless/libertas/fw.c      |    9 +-
 drivers/net/wireless/libertas/if_usb.c  |    5 +-
 drivers/net/wireless/libertas/if_usb.h  |    2 -
 drivers/net/wireless/libertas/ioctl.c   | 1529 +------------------------------
 drivers/net/wireless/libertas/join.c    |  194 +----
 drivers/net/wireless/libertas/join.h    |    7 -
 drivers/net/wireless/libertas/main.c    |    7 +
 drivers/net/wireless/libertas/rx.c      |    4 +-
 drivers/net/wireless/libertas/scan.c    |  203 ++---
 drivers/net/wireless/libertas/scan.h    |   22 +-
 drivers/net/wireless/libertas/tx.c      |    2 +-
 drivers/net/wireless/libertas/version.h |    7 -
 drivers/net/wireless/libertas/wext.c    |  448 +--------
 drivers/net/wireless/libertas/wext.h    |   85 --
 22 files changed, 259 insertions(+), 2955 deletions(-)

Omnibus diff attached as "libertas-cleanups.patch.bz2" due to size concerns.

-- 
John W. Linville
linville@tuxdriver.com

[-- Attachment #2: libertas-cleanups.patch.bz2 --]
[-- Type: application/x-bzip2, Size: 24407 bytes --]

Re: Please pull 'libertas' branch of wireless-2.6

[Jeff Garzik]

John W. Linville wrote:
> The following changes since commit 1f8a6b658a943b4f04a1fc7b3a420360202c86cd:
>   Linus Torvalds (1):
>         Merge git://git.kernel.org/.../bunk/trivial
> 
> are found in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-2.6.git libertas

pulled

Re: Please pull 'libertas' branch of wireless-2.6

[Jeff Garzik]

John W. Linville wrote:
> Lots of stuff here...probably best for 2.6.23...

Is this best for Linux users... or just easy for developers?

Won't putting off all these fixes until 2.6.23 leave the driver released 
in 2.6.22 in shoddy shape?

libertas is upstream now, so we cannot pretend that the driver is 
completely independent from upstream release cycles and maintenance.

libertas fixes should go upstream immediately, since we are in a bugfix 
cycle, and since libertas (from upstream perspective) is about to make 
its big debut on the world stage.

	Jeff

Re: Please pull 'libertas' branch of wireless-2.6

[Dan Williams]

On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote:
> John W. Linville wrote:
> > Lots of stuff here...probably best for 2.6.23...
> 
> Is this best for Linux users... or just easy for developers?
> 
> Won't putting off all these fixes until 2.6.23 leave the driver released 
> in 2.6.22 in shoddy shape?

Not really; it more or less works there.  What's gone on since then is
general driver cleanup (Christoph's comments and more), splitting the
driver so that other bus types can use it (SDIO for example once
Pierre's SDIO patches get upstream), wireless extensions fixes, etc.

> libertas is upstream now, so we cannot pretend that the driver is 
> completely independent from upstream release cycles and maintenance.

True, but some of the stuff in here I didn't think would be suitable
during an -rc cycle, for example the driver splitting and the cleanups
that don't impact function at all, but are good to do nonetheless.

> libertas fixes should go upstream immediately, since we are in a bugfix 
> cycle, and since libertas (from upstream perspective) is about to make 
> its big debut on the world stage.

If you think all the bits from this should just go to 2.6.22, that's
fine with me.  But I don't feel comfortable making that call given what
I thought were the constraints on pushing changes through during an rc
cycle.  When the merge window was open, we backported critical bug fixes
and necessary merge-requirement cleanups to the code in linville's tree,
but avoided changes that didn't impact function.

Dan

Re: Please pull 'libertas' branch of wireless-2.6

[Dan Williams]

On Wed, 2007-05-30 at 11:28 -0400, Dan Williams wrote:
> On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote:
> > John W. Linville wrote:
> > > Lots of stuff here...probably best for 2.6.23...
> > 
> > Is this best for Linux users... or just easy for developers?
> > 
> > Won't putting off all these fixes until 2.6.23 leave the driver released 
> > in 2.6.22 in shoddy shape?
> 
> Not really; it more or less works there.  What's gone on since then is
> general driver cleanup (Christoph's comments and more), splitting the
> driver so that other bus types can use it (SDIO for example once
> Pierre's SDIO patches get upstream), wireless extensions fixes, etc.
> 
> > libertas is upstream now, so we cannot pretend that the driver is 
> > completely independent from upstream release cycles and maintenance.
> 
> True, but some of the stuff in here I didn't think would be suitable
> during an -rc cycle, for example the driver splitting and the cleanups
> that don't impact function at all, but are good to do nonetheless.
> 
> > libertas fixes should go upstream immediately, since we are in a bugfix 
> > cycle, and since libertas (from upstream perspective) is about to make 
> > its big debut on the world stage.
> 
> If you think all the bits from this should just go to 2.6.22, that's
> fine with me.  But I don't feel comfortable making that call given what
> I thought were the constraints on pushing changes through during an rc
> cycle.  When the merge window was open, we backported critical bug fixes
> and necessary merge-requirement cleanups to the code in linville's tree,
> but avoided changes that didn't impact function.

Any response on these points yet?  I've got yet more cleanups and a few
other things queued in libertas-2.6 but I'd like to see where this
discussion goes before sending a pull request for the new bits.

Dan

> Dan
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Please pull 'libertas' branch of wireless-2.6

[John W. Linville]

On Thu, May 31, 2007 at 05:13:17PM -0400, Dan Williams wrote:
> On Wed, 2007-05-30 at 11:28 -0400, Dan Williams wrote:
> > On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote:
> > > John W. Linville wrote:
> > > > Lots of stuff here...probably best for 2.6.23...
> > > 
> > > Is this best for Linux users... or just easy for developers?
> > > 
> > > Won't putting off all these fixes until 2.6.23 leave the driver released 
> > > in 2.6.22 in shoddy shape?

> > If you think all the bits from this should just go to 2.6.22, that's
> > fine with me.  But I don't feel comfortable making that call given what
> > I thought were the constraints on pushing changes through during an rc
> > cycle.  When the merge window was open, we backported critical bug fixes
> > and necessary merge-requirement cleanups to the code in linville's tree,
> > but avoided changes that didn't impact function.
> 
> Any response on these points yet?  I've got yet more cleanups and a few
> other things queued in libertas-2.6 but I'd like to see where this
> discussion goes before sending a pull request for the new bits.

As for me, I have no great problem w/ the whole batch going to 2.6.22.
The driver is still new and most acknowledge it still has significant
defficiencies.  Most (but probably not all) of the patches would seem
to fit some definition of bug fix anyway.  I was just trying to err
on the side of caution and follow the normal "bugfixes in -rc" process.

Jeff, the branch in question is based off a vanilla 2.6.22-rc3.
So it is safe to pull (from a "won't mess-up my tree" perspective)
if you are so inclined.

John
-- 
John W. Linville
linville@tuxdriver.com

Re: Please pull 'libertas' branch of wireless-2.6

[Dan Williams]

On Thu, 2007-05-31 at 17:16 -0400, John W. Linville wrote:
> On Thu, May 31, 2007 at 05:13:17PM -0400, Dan Williams wrote:
> > On Wed, 2007-05-30 at 11:28 -0400, Dan Williams wrote:
> > > On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote:
> > > > John W. Linville wrote:
> > > > > Lots of stuff here...probably best for 2.6.23...
> > > > 
> > > > Is this best for Linux users... or just easy for developers?
> > > > 
> > > > Won't putting off all these fixes until 2.6.23 leave the driver released 
> > > > in 2.6.22 in shoddy shape?
> 
> > > If you think all the bits from this should just go to 2.6.22, that's
> > > fine with me.  But I don't feel comfortable making that call given what
> > > I thought were the constraints on pushing changes through during an rc
> > > cycle.  When the merge window was open, we backported critical bug fixes
> > > and necessary merge-requirement cleanups to the code in linville's tree,
> > > but avoided changes that didn't impact function.
> > 
> > Any response on these points yet?  I've got yet more cleanups and a few
> > other things queued in libertas-2.6 but I'd like to see where this
> > discussion goes before sending a pull request for the new bits.
> 
> As for me, I have no great problem w/ the whole batch going to 2.6.22.
> The driver is still new and most acknowledge it still has significant
> defficiencies.  Most (but probably not all) of the patches would seem
> to fit some definition of bug fix anyway.  I was just trying to err
> on the side of caution and follow the normal "bugfixes in -rc" process.
> 
> Jeff, the branch in question is based off a vanilla 2.6.22-rc3.
> So it is safe to pull (from a "won't mess-up my tree" perspective)
> if you are so inclined.

Ok; if Jeff is so inclined, we'll push further libertas
cleanups/bugfixes/etc to you, and then you upstream to Jeff, targetted
for inclusion in 2.6.22.

Dan