From: Tobias Guggenmos <slartibartfas421@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Johannes Berg <johannes@sipsolutions.net>,
Dmitry Osipenko <digetx@gmail.com>,
Chaoming Li <chaoming_li@realsil.com.cn>,
linux-wireless@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: rtlwifi: rtl8192c_common: "BUG: KASAN: slab-out-of-bounds"
Date: Tue, 07 Feb 2017 17:45:47 +0100 [thread overview]
Message-ID: <46454409.lUoPi3ZtJt@slartibartfas> (raw)
In-Reply-To: <fbe5786e-54eb-b8a7-1540-64a913692361@lwfinger.net>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
Am Montag, 6. Februar 2017, 09:45:31 CET schrieb Larry Finger:
> On 02/06/2017 04:29 AM, Johannes Berg wrote:
> > On Sat, 2017-02-04 at 12:41 -0600, Larry Finger wrote:
> >> On 02/04/2017 10:58 AM, Dmitry Osipenko wrote:
> >>> Seems the problem is caused by rtl92c_dm_*() casting .priv to
> >>> "struct
> >>> rtl_pci_priv", while it is "struct rtl_usb_priv".
> >>
> >> Those routines are shared by rtl8192ce and rtl8192cu, thus we need to
> >> make that
> >> difference in cast to be immaterial. I think we need to move "struct
> >> bt_coexist_info" to the beginning of both rtlpci_priv and
> >> rtl_usb_priv. Then it
> >> should not matter.
> >
> > I think you really should consider putting a struct rtl_common into
> > that or something, and getting rid of all the casting that causes this
> > problem to start with?
>
> The fix you suggest is prepared and will be submitted soon. As it is much
> more invasive with ~150 insertions and ~160 deletions, I decided not to
> have it be the one that is pushed to all stable kernels from 4.0 onward.
>
> Larry
This is possibly related to the following Fedora Bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1391987
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2017-02-07 16:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-04 15:29 rtlwifi: rtl8192c_common: "BUG: KASAN: slab-out-of-bounds" Dmitry Osipenko
2017-02-04 16:58 ` Dmitry Osipenko
2017-02-04 18:41 ` Larry Finger
2017-02-04 19:32 ` Dmitry Osipenko
2017-02-05 1:05 ` Larry Finger
2017-02-05 11:34 ` Dmitry Osipenko
2017-02-05 17:30 ` Larry Finger
2017-02-05 18:15 ` Dmitry Osipenko
2017-02-07 17:22 ` Tobias Guggenmos
2017-02-07 17:42 ` Dmitry Osipenko
2017-02-06 10:29 ` Johannes Berg
2017-02-06 15:45 ` Larry Finger
2017-02-07 16:45 ` Tobias Guggenmos [this message]
2017-02-07 17:14 ` Dmitry Osipenko
2017-02-08 0:45 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46454409.lUoPi3ZtJt@slartibartfas \
--to=slartibartfas421@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=digetx@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox