From: Claudiu Beznea <Claudiu.Beznea@microchip.com>
To: Ajay Singh <ajay.kathat@microchip.com>, <linux-wireless@vger.kernel.org>
Cc: <devel@driverdev.osuosl.org>, <gregkh@linuxfoundation.org>,
<ganesh.krishna@microchip.com>, <venkateswara.kaja@microchip.com>,
<aditya.shankar@microchip.com>, <adham.abozaeid@microchip.com>
Subject: Re: [PATCH 00/23] staging: wilc1000: cleanup patch to follow linux coding style
Date: Thu, 19 Jul 2018 11:36:45 +0300 [thread overview]
Message-ID: <4645c136-eaad-01a9-cebe-abff6f4dce3e@microchip.com> (raw)
In-Reply-To: <1531953919-20804-1-git-send-email-ajay.kathat@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
On 19.07.2018 01:44, Ajay Singh wrote:
> This patch series contains modification to follow Linux coding style &
> cleanup change to remove unused variables and enums.
> Few patches also contain changes to remove unnecessary typecast.
>
> Ajay Singh (23):
> staging: wilc1000: remove unused enum declaration
> staging: wilc1000: remove enum connect_status instead use
> ieee80211_statuscode
> staging: wilc1000: remove extra enum defined for data rates
> staging: wilc1000: remove extra enums defined for ieee80211_eid
> staging: wilc1000: rename goto to avoid leading '_' in label name
> staging: wilc1000: rename enum CURRENT_TXRATE to use lowercase
> staging: wilc1000: rename enum SITESURVEY to use lowercase
> staging: wilc1000: rename enum AUTHTYPE to use lowercase
> staging: wilc1000: remove unused elements in 'wilc' struct
> staging: wilc1000: remove unnecessary elements from 'wilc_priv' struct
> staging: wilc1000: removed unused element from wilc_cfg_frame struct
> staging: wilc1000: remove the mutliple #define used for same macro
> staging: wilc1000: use lowercase for 'IFC_UP' struct element name
> staging: wilc1000: remove unnecessary blank line between variable
> declaration
> staging: wilc1000: use single space before opening brances '{'
> staging: wilc1000: remove unnecessary type used for wid id
> staging: wilc1000: avoid forward declaration for handle_scan_done()
> staging: wilc1000: avoid host_int_get_assoc_res_info() forward
> declaration
> staging: wilc1000: avoid forward declaration of
> host_int_parse_join_bss_param()
> staging: wilc1000: avoid setting default value for variable at
> declaration
> staging: wilc1000: use 'int' inplace of 's32' date type
> staging: wilc1000: remove unnecessary 'NULL' check from cfg80211_ops
> callbacks
> staging: wilc1000: move variable assignment along with its declaration
>
> drivers/staging/wilc1000/coreconfigurator.c | 84 +--
> drivers/staging/wilc1000/coreconfigurator.h | 20 -
> drivers/staging/wilc1000/host_interface.c | 696 +++++++++++-----------
> drivers/staging/wilc1000/host_interface.h | 20 +-
> drivers/staging/wilc1000/linux_mon.c | 2 -
> drivers/staging/wilc1000/linux_wlan.c | 122 ++--
> drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 307 +++-------
> drivers/staging/wilc1000/wilc_wfi_netdevice.h | 16 +-
> drivers/staging/wilc1000/wilc_wlan.c | 65 +-
> drivers/staging/wilc1000/wilc_wlan.h | 3 -
> drivers/staging/wilc1000/wilc_wlan_if.h | 56 +-
> 11 files changed, 517 insertions(+), 874 deletions(-)
>
prev parent reply other threads:[~2018-07-19 9:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 22:44 [PATCH 00/23] staging: wilc1000: cleanup patch to follow linux coding style Ajay Singh
2018-07-18 22:44 ` [PATCH 01/23] staging: wilc1000: remove unused enum declaration Ajay Singh
2018-07-18 22:44 ` [PATCH 02/23] staging: wilc1000: remove enum connect_status instead use ieee80211_statuscode Ajay Singh
2018-07-18 22:44 ` [PATCH 03/23] staging: wilc1000: remove extra enum defined for data rates Ajay Singh
2018-07-18 22:45 ` [PATCH 04/23] staging: wilc1000: remove extra enums defined for ieee80211_eid Ajay Singh
2018-07-18 22:45 ` [PATCH 05/23] staging: wilc1000: rename goto to avoid leading '_' in label name Ajay Singh
2018-07-19 9:27 ` Dan Carpenter
2018-07-19 23:05 ` Ajay Singh
2018-07-30 8:41 ` Dan Carpenter
2018-07-30 10:10 ` Ajay Singh
2018-07-30 11:32 ` Dan Carpenter
2018-08-01 5:16 ` Ajay Singh
2018-08-01 8:11 ` Dan Carpenter
2018-07-18 22:45 ` [PATCH 06/23] staging: wilc1000: rename enum CURRENT_TXRATE to use lowercase Ajay Singh
2018-07-18 22:45 ` [PATCH 07/23] staging: wilc1000: rename enum SITESURVEY " Ajay Singh
2018-07-18 22:45 ` [PATCH 08/23] staging: wilc1000: rename enum AUTHTYPE " Ajay Singh
2018-07-18 22:45 ` [PATCH 09/23] staging: wilc1000: remove unused elements in 'wilc' struct Ajay Singh
2018-07-18 22:45 ` [PATCH 10/23] staging: wilc1000: remove unnecessary elements from 'wilc_priv' struct Ajay Singh
2018-07-18 22:45 ` [PATCH 11/23] staging: wilc1000: removed unused element from wilc_cfg_frame struct Ajay Singh
2018-07-18 22:45 ` [PATCH 12/23] staging: wilc1000: remove the mutliple #define used for same macro Ajay Singh
2018-07-18 22:45 ` [PATCH 13/23] staging: wilc1000: use lowercase for 'IFC_UP' struct element name Ajay Singh
2018-07-18 22:45 ` [PATCH 14/23] staging: wilc1000: remove unnecessary blank line between variable declaration Ajay Singh
2018-07-18 22:45 ` [PATCH 15/23] staging: wilc1000: use single space before opening brances '{' Ajay Singh
2018-07-18 22:45 ` [PATCH 16/23] staging: wilc1000: remove unnecessary type used for wid id Ajay Singh
2018-07-18 22:45 ` [PATCH 17/23] staging: wilc1000: avoid forward declaration for handle_scan_done() Ajay Singh
2018-07-18 22:45 ` [PATCH 18/23] staging: wilc1000: avoid host_int_get_assoc_res_info() forward declaration Ajay Singh
2018-07-18 22:45 ` [PATCH 19/23] staging: wilc1000: avoid forward declaration of host_int_parse_join_bss_param() Ajay Singh
2018-07-18 22:45 ` [PATCH 20/23] staging: wilc1000: avoid setting default value for variable at declaration Ajay Singh
2018-07-18 22:45 ` [PATCH 21/23] staging: wilc1000: use 'int' inplace of 's32' date type Ajay Singh
2018-07-18 22:45 ` [PATCH 22/23] staging: wilc1000: remove unnecessary 'NULL' check from cfg80211_ops callbacks Ajay Singh
2018-07-18 22:45 ` [PATCH 23/23] staging: wilc1000: move variable assignment along with its declaration Ajay Singh
2018-07-19 8:36 ` Claudiu Beznea [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4645c136-eaad-01a9-cebe-abff6f4dce3e@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=adham.abozaeid@microchip.com \
--cc=aditya.shankar@microchip.com \
--cc=ajay.kathat@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=ganesh.krishna@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=venkateswara.kaja@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).