From: Jeff Garzik <jeff@garzik.org>
To: James Ketrenos <jketreno@linux.intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] Add iwlwifi wireless drivers
Date: Fri, 18 May 2007 16:57:49 -0400 [thread overview]
Message-ID: <464E134D.60000@garzik.org> (raw)
In-Reply-To: <464DF7FC.5070702@linux.intel.com>
James Ketrenos wrote:
> Randy Dunlap wrote:
>> 15. Limit source lines to <= 80 columns (this patch contains
>> over 200 lines that are > 80 columns).
>
> Fixed in the .c files. Still have 155 instances in the .h files (most
> due to mid-line tabs)
See my email on this subject. This is NOT a hard and fast rule. If you
have to do something stupid to the formatting to get it to fit, then you
are moving in the wrong direction.
As an aside, sometimes long lines are an indication that a function
needs to be broken up into smaller sub-functions.
Jeff
next prev parent reply other threads:[~2007-05-18 20:57 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 21:45 [PATCH] Add iwlwifi wireless drivers James Ketrenos
2007-05-17 1:27 ` Randy Dunlap
2007-05-17 4:28 ` James Ketrenos
2007-05-17 5:57 ` Jeff Garzik
2007-05-22 21:38 ` James Ketrenos
2007-05-18 19:01 ` James Ketrenos
2007-05-18 20:57 ` Jeff Garzik [this message]
2007-05-18 20:54 ` James Ketrenos
2007-05-18 21:06 ` Randy Dunlap
2007-05-22 18:39 ` John W. Linville
2007-05-22 18:29 ` James Ketrenos
2007-05-17 1:51 ` Michael Wu
2007-05-17 2:56 ` Jeff Garzik
2007-05-17 3:55 ` Michael Wu
2007-05-17 8:52 ` Christoph Hellwig
2007-05-22 19:16 ` James Ketrenos
2007-05-22 23:00 ` Jeff Garzik
2007-05-22 21:49 ` James Ketrenos
2007-05-22 23:41 ` Jeff Garzik
2007-05-22 22:56 ` James Ketrenos
2007-05-23 0:58 ` Jeff Garzik
2007-05-23 18:17 ` James Ketrenos
2007-05-23 19:59 ` Jeff Garzik
2007-05-23 19:30 ` James Ketrenos
2007-05-23 1:06 ` Michael Wu
2007-05-23 1:46 ` Jeff Garzik
2007-05-17 3:35 ` [PATCH] Add iwlwifi wireless drivers [part 2/2] Randy Dunlap
2007-05-17 15:03 ` Stephen Hemminger
2007-05-17 15:05 ` Stephen Hemminger
2007-05-18 7:04 ` Johannes Berg
2007-05-18 20:33 ` James Ketrenos
2007-05-18 22:05 ` Jeff Garzik
2007-05-18 21:31 ` James Ketrenos
2007-05-18 22:50 ` Jeff Garzik
2007-05-18 23:04 ` Christoph Hellwig
2007-05-21 14:56 ` James Ketrenos
2007-05-21 16:26 ` Christoph Hellwig
2007-05-21 16:48 ` James Ketrenos
2007-05-21 18:15 ` Christoph Hellwig
2007-05-21 20:12 ` Cohen, Guy
2007-05-21 21:02 ` Jeff Garzik
2007-05-21 21:10 ` Randy Dunlap
2007-05-21 21:43 ` Cohen, Guy
2007-05-21 22:15 ` Jeff Garzik
2007-05-21 21:22 ` Joerg Mayer
2007-05-21 21:46 ` Cohen, Guy
2007-05-18 22:13 ` Randy Dunlap
2007-05-18 23:05 ` [PATCH] Add iwlwifi wireless drivers Christoph Hellwig
2007-05-18 23:22 ` Michael Wu
2007-05-22 21:50 ` [PATCH v3] " James Ketrenos
2007-05-23 1:06 ` Jeff Garzik
2007-05-23 15:16 ` James Ketrenos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464E134D.60000@garzik.org \
--to=jeff@garzik.org \
--cc=jketreno@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).