From: Eugene Teo <eteo@redhat.com>
To: linux-wireless@vger.kernel.org
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-kernel@vger.kernel.org, jeff@garzik.org,
Florin Malita <fmalita@gmail.com>
Subject: Re: [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free
Date: Sat, 19 May 2007 11:14:10 +0800 [thread overview]
Message-ID: <464E6B82.40607@redhat.com> (raw)
In-Reply-To: <20070518174623.GA3492@tuxdriver.com>
John W. Linville wrote:
> First, please send all wireless patches to
> linux-wireless@vger.kernel.org, and be sure to CC me as well...thanks!
>
> On Sat, May 19, 2007 at 12:50:31AM +0800, Eugene Teo wrote:
>> libertas_upload_rx_packet() calls netif_rx() before returning, and it always return 0.
>> Also within libertas_upload_rx_packet(), it will initialize skb->protocol anyways.
>>
>> Spotted by the Coverity checker.
>
> A nearly identical patch was posted by Florin Malita <fmalita@gmail.com>
> to netdev (also the wrong list) on Wednesday evening.
Nod. I wasn't subscribed to netdev list.
>> done:
>> LEAVE();
>>
>> - skb->protocol = __constant_htons(0x0019); /* ETH_P_80211_RAW */
>> -
>
> Except for this part...is this intentional?
skb could have been freed by then. And, in libertas_upload_rx_packet(), skb->protocol
is initialized by eth_type_trans(skb, priv->wlan_dev.netdev).
Eugene
next prev parent reply other threads:[~2007-05-19 3:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <464DD957.9040803@redhat.com>
2007-05-18 17:46 ` [2.6 patch] drivers/net/wireless/libertas/rx.c: fix use-after-free John W. Linville
2007-05-19 3:14 ` Eugene Teo [this message]
2007-05-21 13:31 ` John W. Linville
2007-05-21 14:30 ` Eugene Teo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464E6B82.40607@redhat.com \
--to=eteo@redhat.com \
--cc=fmalita@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).