From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Joe Jezak <josejx@gentoo.org>, Daniel Drake <dsd@gentoo.org>
Subject: Re: [PATCH] softmac: use list_for_each_entry
Date: Fri, 01 Jun 2007 10:59:53 -0500 [thread overview]
Message-ID: <46604279.3070908@lwfinger.net> (raw)
In-Reply-To: <1180643064.18266.2.camel@johannes.berg>
Johannes,
Johannes Berg wrote:
> On Sun, 2007-05-27 at 23:27 +0900, Akinobu Mita wrote:
>> Cleanup using list_for_each_entry.
>
>> This patch adds missing NULL check and trims a line longer than 80
>> columns.
>
> Both patches look good to me but I do wonder why you're actually looking
> at this code :)
>
> I sure hope somebody will port bcm43xx driver to mac80211 (again) soon
> so we can remove softmac.
As it is impossible to predict how long until we can remove softmac, such patches should be
accepted. You understand that I'm not looking for problems in softmac.
As we discussed earlier, bcm43xx-softmac has to be ported to mac80211 to support 802.11b-only cards,
as the V4 firmware does not accommodate them. I had started this project by changing the namespace
to bcm4301. That patch went into Linville's wireless-dev pending list. I then started learning the
interface to mac80211. For a number of reasons, that step was going slowly. Michael Wu recently
offered to take over, which seemed reasonable given his familiarity with mac80211.
When Michael Wu gets a version of bcm4301-mac80211 that compiles cleanly, I will be testing it as he
doesn't have the hardware. For my testing purposes, the 802.11g stuff will still be there. Once I
get it working, I plan to post a patch to get as much testing as possible.
In the earlier discussion, we also concluded that the product of a conversion from softmac to
mac80211 should not be included in mainline, with the exception of the b-only code. Depending on how
long the port and testing take, and the state of bcm43xx-mac80211 at that time, a reversal of that
earlier decision may be in order.
Larry
next prev parent reply other threads:[~2007-06-01 16:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-27 14:27 [PATCH] softmac: use list_for_each_entry Akinobu Mita
2007-05-31 20:24 ` Johannes Berg
2007-06-01 15:59 ` Larry Finger [this message]
2007-06-01 19:12 ` Johannes Berg
2007-06-11 19:18 ` John W. Linville
2007-06-11 20:06 ` John W. Linville
2007-06-11 20:14 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46604279.3070908@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=akinobu.mita@gmail.com \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=josejx@gentoo.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).