From: James Ketrenos <jketreno@linux.intel.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Michael Wu <flamingice@sourmilk.net>, Jiri Benc <jbenc@suse.cz>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Update stop_queues kdoc
Date: Fri, 01 Jun 2007 09:58:36 -0700 [thread overview]
Message-ID: <4660503C.9080309@linux.intel.com> (raw)
In-Reply-To: <200706011129.12432.mb@bu3sch.de>
Michael Buesch wrote:
> This updates stop_queue(s) kdoc as currently there's
> a undocumented dependency.
>
> Stopping the queue from anywhere else than the ops->tx()
> callback will result in a hard to debug deadlock and
> system freeze (on UP).
...
> --
>
> I'd still prefer someone fixes the issue. I don't understand
> the code well enough to fix it.
Perhaps having ieee80211_stop_queue keep a mac80211 internal state flag that is checked within the Tx operation before the driver's Tx callback is made. Then, if that bit is set, mac80211 can invoke the internal "deadlock if outside of Tx" queue stop action to halt Tx?
In this way we are putting in a work around that doesn't result in an API change, and that can eventually (hopefully) be fixed the "right way" (whatever that may end up being)
James
next prev parent reply other threads:[~2007-06-01 18:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-01 9:29 [PATCH] mac80211: Update stop_queues kdoc Michael Buesch
2007-06-01 9:48 ` Johannes Berg
2007-06-01 9:53 ` Michael Buesch
2007-06-01 11:55 ` Olivier Cornu
2007-06-01 20:42 ` Michael Buesch
2007-06-01 21:00 ` Olivier Cornu
2007-06-01 21:42 ` Michael Buesch
2007-06-01 21:53 ` Olivier Cornu
2007-06-02 13:17 ` Olivier Cornu
2007-06-02 13:37 ` Michael Buesch
2007-06-02 18:41 ` Olivier Cornu
2007-06-01 16:58 ` James Ketrenos [this message]
2007-06-01 19:04 ` Michael Wu
2007-06-01 17:32 ` James Ketrenos
2007-06-01 20:36 ` Michael Wu
2007-06-01 20:52 ` Michael Buesch
2007-06-01 20:41 ` Michael Buesch
2007-06-01 20:52 ` Olivier Cornu
2007-06-01 20:54 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4660503C.9080309@linux.intel.com \
--to=jketreno@linux.intel.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).