linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: James Ketrenos <jketreno@linux.intel.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jiri Benc <jbenc@suse.cz>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Add module parameter for setting initial rate  in rc80211_simple
Date: Mon, 04 Jun 2007 11:05:44 -0700	[thread overview]
Message-ID: <46645478.20002@linux.intel.com> (raw)
In-Reply-To: <46644D8F.2010400@linux.intel.com>

James Ketrenos wrote:
> Larry Finger wrote:
>> The initial rate for STA's using rc80211_simple is set to the last
>> rate in the rate table. This is too fast for the bcm43xx-mac80211
>> driver.
>> To correct this situation without affecting any other driver,
>> an initial_rate parameter is added to the rc80211_simple module. This
>> parameter is set to 10 times the desired initial rate. If the parameter
>> is zero or not set, the original behavior is kept. If the parameter
>> does not match a valid rate, the first rate in the table will be set.
> 
> Initial rate selection should be based on the RSSI of the last frame(s) 
> received from the target network.  One way to do that would be for the 
> driver to map a minimum RSSI value to each rate.  If the RSSI for the 
> target network is greater than the value listed, that rate could be used 
> for initial selection.  The ieee80211_rate with the highest 'rate', 
> which is in the supported rates mask and with a min_rssi <= the AP's 
> reported RSSI, is selected.
> 
> The mechanism by which the magic values for min_rssi are determined for 
> each rate is more observational than scientific--and is vendor 
> specific.  You can pick a set of values, but different hardware and 
> environments will yield different levels of success / failure.  Some 
> hardware can be very lenient if it has automatic hardware retry.  Other 
> hardware will need to be very conservative (since, as you point out, the 
> first few frames Tx/Rx'd are important)

I didn't state it above -- doing what is described requires adding one unsigned char (min_rssi) to ieee80211_rate in mac80211.h and then modifying rc80211_simple to take advantage of that information (so if you're grepping for min_rssi and can't find it, that's why...)

James

> 
> James
> 
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2007-06-04 20:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02 18:51 [PATCH] mac80211: Add module parameter for setting initial rate in rc80211_simple Larry Finger
2007-06-03 10:33 ` Olivier Cornu
2007-06-03 10:45   ` Michael Buesch
2007-06-03 10:50     ` stefano.brivio
2007-06-03 19:14     ` Larry Finger
2007-06-03 18:51   ` Larry Finger
2007-06-04 11:44 ` Johannes Berg
2007-06-04 17:36 ` James Ketrenos
2007-06-04 18:05   ` James Ketrenos [this message]
2007-06-05 12:40     ` Larry Finger
2007-06-07 20:19 ` Jiri Benc
2007-06-07 20:21   ` [PATCH] mac80211: allow changing of rate control algorithm Jiri Benc
2007-06-07 20:22     ` [PATCH] mac80211: rc80211_lowest, a dumb " Jiri Benc
2007-06-07 20:54       ` Jouni Malinen
2007-06-07 21:06         ` Jiri Benc
2007-06-08  0:50       ` Larry Finger
2007-06-08  8:59         ` Jiri Benc
2007-06-08  9:04           ` Johannes Berg
2007-06-08  9:06           ` Johannes Berg
2007-06-08 12:27             ` Larry Finger
2007-06-07 21:22   ` [PATCH] mac80211: Add module parameter for setting initial rate in rc80211_simple Larry Finger
2007-06-07 22:19     ` Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46645478.20002@linux.intel.com \
    --to=jketreno@linux.intel.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).