linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Add module parameter for setting initial rate  in rc80211_simple
Date: Thu, 07 Jun 2007 16:22:52 -0500	[thread overview]
Message-ID: <4668772C.1000107@lwfinger.net> (raw)
In-Reply-To: <20070607221939.444e9d74@griffin.suse.cz>

Jiri Benc wrote:
> 
> Don't misuse module parameters, please. If you have more devices, this
> single parameter will affect all of them. That's not a good approach,
> especially when the value you are trying to change can be changed on
> the fly.
--- snip ---
> However, I'm not against setting the initial value to the lowest rate
> available. As Johannes pointed out, if the rate control algorithm isn't
> able to quickly migrate to higher rates, it's a good candidate for
> rewrite.

I'm more than a little confused. First you tell me that setting the initial rate with a module 
parameter is bad because it sets a value for all _MY_ devices, then you say that you will allow a 
change that would affect _EVERYONE'S_ devices. Huh? I wrote the code the way I did because I thought 
it was much better to allow a local solution rather than a global one.

Larry


  parent reply	other threads:[~2007-06-07 21:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-02 18:51 [PATCH] mac80211: Add module parameter for setting initial rate in rc80211_simple Larry Finger
2007-06-03 10:33 ` Olivier Cornu
2007-06-03 10:45   ` Michael Buesch
2007-06-03 10:50     ` stefano.brivio
2007-06-03 19:14     ` Larry Finger
2007-06-03 18:51   ` Larry Finger
2007-06-04 11:44 ` Johannes Berg
2007-06-04 17:36 ` James Ketrenos
2007-06-04 18:05   ` James Ketrenos
2007-06-05 12:40     ` Larry Finger
2007-06-07 20:19 ` Jiri Benc
2007-06-07 20:21   ` [PATCH] mac80211: allow changing of rate control algorithm Jiri Benc
2007-06-07 20:22     ` [PATCH] mac80211: rc80211_lowest, a dumb " Jiri Benc
2007-06-07 20:54       ` Jouni Malinen
2007-06-07 21:06         ` Jiri Benc
2007-06-08  0:50       ` Larry Finger
2007-06-08  8:59         ` Jiri Benc
2007-06-08  9:04           ` Johannes Berg
2007-06-08  9:06           ` Johannes Berg
2007-06-08 12:27             ` Larry Finger
2007-06-07 21:22   ` Larry Finger [this message]
2007-06-07 22:19     ` [PATCH] mac80211: Add module parameter for setting initial rate in rc80211_simple Jiri Benc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4668772C.1000107@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).