linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <larry.finger@lwfinger.net>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Jiri Benc <jbenc@suse.cz>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] mac80211: Set low initial rate in rc80211_simple
Date: Thu, 07 Jun 2007 22:08:40 -0500	[thread overview]
Message-ID: <4668C838.20301@lwfinger.net> (raw)
In-Reply-To: <4668c4f6.9foQu67PRVz5Fh3G%Larry.Finger@lwfinger.net>

Larry Finger wrote:
> The initial rate for STA's using rc80211_simple is set to the last
> rate in the rate table. For situations for which the signal is weak,
> the rate may be too high for authentication and association. Although
> the rc80211_simple module will adjust the speed, the response may not
> be fast enough for a successful connection. This modification sets the
> initial rate to the lowest supported value.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> 
> Index: wireless-dev/net/mac80211/rc80211_simple.c
> ===================================================================
> --- wireless-dev.orig/net/mac80211/rc80211_simple.c
> +++ wireless-dev/net/mac80211/rc80211_simple.c
> @@ -283,10 +283,10 @@ static void rate_control_simple_rate_ini
>  	int i;
>  	sta->txrate = 0;
>  	mode = local->oper_hw_mode;
> -	/* TODO: what is a good starting rate for STA? About middle? Maybe not
> -	 * the lowest or the highest rate.. Could consider using RSSI from
> -	 * previous packets? Need to have IEEE 802.1X auth succeed immediately
> -	 * after assoc.. */
> +	/* TODO: This routine should consider using RSSI from previous packets
> +	 * as we need to have IEEE 802.1X auth succeed immediately after assoc..
> +	 * Until that method is implemented, we will use the lowest supported rate
> +	 * as a workaround, */
>  	for (i = 0; i < mode->num_rates; i++) {
>  		if ((sta->supp_rates & BIT(i)) &&
>  		    (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
> 

I missed a refresh on this patch. Corrected one to follow.

Larry


      reply	other threads:[~2007-06-08  3:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-08  2:54 [PATCH V2] mac80211: Set low initial rate in rc80211_simple Larry Finger
2007-06-08  3:08 ` Larry Finger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4668C838.20301@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).