[PATCH V2] mac80211: Set low initial rate in rc80211_simple

[PATCH V2] mac80211: Set low initial rate in rc80211_simple

[Larry Finger]

The initial rate for STA's using rc80211_simple is set to the last
rate in the rate table. For situations for which the signal is weak,
the rate may be too high for authentication and association. Although
the rc80211_simple module will adjust the speed, the response may not
be fast enough for a successful connection. This modification sets the
initial rate to the lowest supported value.

Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---


Index: wireless-dev/net/mac80211/rc80211_simple.c
===================================================================
--- wireless-dev.orig/net/mac80211/rc80211_simple.c
+++ wireless-dev/net/mac80211/rc80211_simple.c
@@ -283,10 +283,10 @@ static void rate_control_simple_rate_ini
 	int i;
 	sta->txrate = 0;
 	mode = local->oper_hw_mode;
-	/* TODO: what is a good starting rate for STA? About middle? Maybe not
-	 * the lowest or the highest rate.. Could consider using RSSI from
-	 * previous packets? Need to have IEEE 802.1X auth succeed immediately
-	 * after assoc.. */
+	/* TODO: This routine should consider using RSSI from previous packets
+	 * as we need to have IEEE 802.1X auth succeed immediately after assoc..
+	 * Until that method is implemented, we will use the lowest supported rate
+	 * as a workaround, */
 	for (i = 0; i < mode->num_rates; i++) {
 		if ((sta->supp_rates & BIT(i)) &&
 		    (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))

Re: [PATCH V2] mac80211: Set low initial rate in rc80211_simple

[Larry Finger]

Larry Finger wrote:
> The initial rate for STA's using rc80211_simple is set to the last
> rate in the rate table. For situations for which the signal is weak,
> the rate may be too high for authentication and association. Although
> the rc80211_simple module will adjust the speed, the response may not
> be fast enough for a successful connection. This modification sets the
> initial rate to the lowest supported value.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> 
> Index: wireless-dev/net/mac80211/rc80211_simple.c
> ===================================================================
> --- wireless-dev.orig/net/mac80211/rc80211_simple.c
> +++ wireless-dev/net/mac80211/rc80211_simple.c
> @@ -283,10 +283,10 @@ static void rate_control_simple_rate_ini
>  	int i;
>  	sta->txrate = 0;
>  	mode = local->oper_hw_mode;
> -	/* TODO: what is a good starting rate for STA? About middle? Maybe not
> -	 * the lowest or the highest rate.. Could consider using RSSI from
> -	 * previous packets? Need to have IEEE 802.1X auth succeed immediately
> -	 * after assoc.. */
> +	/* TODO: This routine should consider using RSSI from previous packets
> +	 * as we need to have IEEE 802.1X auth succeed immediately after assoc..
> +	 * Until that method is implemented, we will use the lowest supported rate
> +	 * as a workaround, */
>  	for (i = 0; i < mode->num_rates; i++) {
>  		if ((sta->supp_rates & BIT(i)) &&
>  		    (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
> 

I missed a refresh on this patch. Corrected one to follow.

Larry