From: jketreno <jketreno@linux.intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: yi.zhu@intel.com, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH 1/3] mac80211: add IEEE802.11e/WMM structures
Date: Thu, 07 Jun 2007 21:32:33 -0700 [thread overview]
Message-ID: <4668DBE1.5090201@linux.intel.com> (raw)
In-Reply-To: <20070607223058.44122be4@griffin.suse.cz>
Jiri Benc wrote:
> On Wed, 6 Jun 2007 16:22:10 +0800, Zhu Yi wrote:
>> --- a/include/linux/ieee80211.h
>> +++ b/include/linux/ieee80211.h
>> @@ -106,6 +106,52 @@ struct ieee80211_hdr {
...
>> +enum wifi_oui_stype_wmm {
>> + WIFI_OUI_STYPE_WMM_INFO = 0,
>> + WIFI_OUI_STYPE_WMM_PARAM = 1,
>> + WIFI_OUI_STYPE_WMM_TSPEC = 2,
>> +};
>
> Please don't invent new useless prefixes.
It doesn't really look like he invented a 'new useless' prefix. It looks to me like he picked a prefix that correlates attribution of the data declaration to the entity that created it. You may not like that he provided attribution, but that doesn't mean its useless.
If you'd rather use a different prefix, send a patch to fix it.
> Also, a registered trademark doesn't seem to be a good prefix.
Who holds 'WIFI' as a registered trademark?
James
next prev parent reply other threads:[~2007-06-07 21:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 8:22 [PATCH 1/3] mac80211: add IEEE802.11e/WMM structures Zhu Yi
2007-06-07 20:30 ` Jiri Benc
2007-06-08 1:34 ` Zhu Yi
2007-06-08 7:23 ` Johannes Berg
2007-06-08 10:07 ` Jiri Benc
2007-06-08 4:32 ` jketreno [this message]
2007-06-07 22:49 ` Jiri Benc
2007-06-07 22:59 ` Jouni Malinen
2007-06-08 2:14 ` Michael Wu
2007-06-08 3:40 ` Zhu Yi
2007-06-08 10:16 ` Jiri Benc
2007-06-08 16:38 ` Zhu Yi
-- strict thread matches above, loose matches on Subject: below --
2007-05-25 11:52 Zhu Yi
2007-05-14 5:15 Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4668DBE1.5090201@linux.intel.com \
--to=jketreno@linux.intel.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).