linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [PATCH Try#8 3/4] cfg80211: Radiotap parser
Date: Mon, 11 Jun 2007 16:27:28 +0100	[thread overview]
Message-ID: <466D69E0.7020204@warmcat.com> (raw)
In-Reply-To: <1181560668.29767.8.camel@johannes.berg>

Johannes Berg wrote:

Hi Johannes -

>> + * care of alignment handling and extended present fields.  interator->this_arg
> 
> typo: "interator", also I don't understand why you would want to change
> this_arg?

Thanks for the comments which I addressed in try #9.

iterator->this_arg can make sense to increment when you are walking
through one of the compound arguments, like the channel one, the comment
means you don't have to take care to preserve it during the processing
of any argument in your loop.

I did move the function comments into cfg80211 but I didn't prefer it
and when I read Randy's take I moved them back.

-Andy

  parent reply	other threads:[~2007-06-11 15:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-11  9:54 [PATCH Try#8 0/4] Radiotap injection for Monitor Mode andy
2007-06-11  9:54 ` [PATCH Try#8 1/4] mac80211: Monitor mode radiotap injection docs andy
2007-06-11  9:54 ` [PATCH Try#8 2/4] mac80211: Define present bitmap extend bit mask andy
2007-06-11  9:54 ` [PATCH Try#8 3/4] cfg80211: Radiotap parser andy
2007-06-11 11:17   ` Johannes Berg
2007-06-11 15:11     ` Randy Dunlap
2007-06-11 15:27     ` Andy Green [this message]
2007-06-11  9:54 ` [PATCH Try#8 4/4] mac80211: Monitor mode radiotap-based packet injection andy
2007-06-11 11:24   ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=466D69E0.7020204@warmcat.com \
    --to=andy@warmcat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).