From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Jiri Benc <jbenc@suse.cz>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] mac80211: Implementation of SIOCSIWRATE
Date: Mon, 11 Jun 2007 11:19:09 -0500 [thread overview]
Message-ID: <466D75FD.9090809@lwfinger.net> (raw)
In-Reply-To: <200706072012.56652.flamingice@sourmilk.net>
Michael Wu wrote:
> On Thursday 07 June 2007 19:56, Larry Finger wrote:
>> When I leave this part out, the rate _NEVER_ gets set, no matter what you
>> say. My experiments say that it is needed.
>>
> That's because force_unicast_rateidx and max_ratectrl_rateidx is being set in
> the wrong struct ieee80211_if_ap. (how did I miss that..) sdata->u.ap is only
> valid when sdata->type == IEEE80211_IF_TYPE_AP, yet it's being accessed
> without any mode checks. sdata->bss should be used instead.
Does sdata->bss need to be checked to verify that it is not NULL?
Larry
next prev parent reply other threads:[~2007-06-11 16:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 0:43 [PATCH V2] mac80211: Implementation of SIOCSIWRATE Larry Finger
2007-06-08 1:19 ` Michael Wu
2007-06-08 2:56 ` Larry Finger
2007-06-08 3:12 ` Michael Wu
2007-06-11 16:19 ` Larry Finger [this message]
2007-06-11 17:10 ` Michael Wu
2007-06-08 4:02 ` Larry Finger
2007-06-08 5:07 ` Michael Wu
2007-06-12 20:35 ` Larry Finger
2007-06-12 20:50 ` Michael Wu
-- strict thread matches above, loose matches on Subject: below --
2007-06-08 0:43 Larry Finger
2007-06-08 0:45 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466D75FD.9090809@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).