From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH] fix oversight in "mac80211: Set low initial rate in rc80211_simple"
Date: Mon, 11 Jun 2007 11:22:04 -0500 [thread overview]
Message-ID: <466D76AC.1090308@lwfinger.net> (raw)
In-Reply-To: <1181542241.3566.23.camel@johannes.berg>
Johannes Berg wrote:
> This fixes a logic oversight in the patch "mac80211: Set low initial
> rate in rc80211_simple".
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> --- wireless-dev.orig/net/mac80211/rc80211_simple.c 2007-06-11 08:08:55.301879260 +0200
> +++ wireless-dev/net/mac80211/rc80211_simple.c 2007-06-11 08:09:06.791879260 +0200
> @@ -289,9 +289,10 @@ static void rate_control_simple_rate_ini
> * as a workaround, */
> for (i = 0; i < mode->num_rates; i++) {
> if ((sta->supp_rates & BIT(i)) &&
> - (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
> + (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED)) {
> sta->txrate = i;
> break;
> + }
> }
> }
Thanks for this one - it is what I intended all along as indicated by the indentation. Now I
understand Michael Wu's comments regarding the loop.
Larry
prev parent reply other threads:[~2007-06-11 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-11 6:10 [PATCH] fix oversight in "mac80211: Set low initial rate in rc80211_simple" Johannes Berg
2007-06-11 16:22 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=466D76AC.1090308@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).