* [PATCH] fix oversight in "mac80211: Set low initial rate in rc80211_simple"
@ 2007-06-11 6:10 Johannes Berg
2007-06-11 16:22 ` Larry Finger
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2007-06-11 6:10 UTC (permalink / raw)
To: linux-wireless; +Cc: Larry Finger, John W. Linville
This fixes a logic oversight in the patch "mac80211: Set low initial
rate in rc80211_simple".
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
--- wireless-dev.orig/net/mac80211/rc80211_simple.c 2007-06-11 08:08:55.301879260 +0200
+++ wireless-dev/net/mac80211/rc80211_simple.c 2007-06-11 08:09:06.791879260 +0200
@@ -289,9 +289,10 @@ static void rate_control_simple_rate_ini
* as a workaround, */
for (i = 0; i < mode->num_rates; i++) {
if ((sta->supp_rates & BIT(i)) &&
- (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
+ (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED)) {
sta->txrate = i;
break;
+ }
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix oversight in "mac80211: Set low initial rate in rc80211_simple"
2007-06-11 6:10 [PATCH] fix oversight in "mac80211: Set low initial rate in rc80211_simple" Johannes Berg
@ 2007-06-11 16:22 ` Larry Finger
0 siblings, 0 replies; 2+ messages in thread
From: Larry Finger @ 2007-06-11 16:22 UTC (permalink / raw)
To: Johannes Berg; +Cc: linux-wireless, John W. Linville, Michael Wu
Johannes Berg wrote:
> This fixes a logic oversight in the patch "mac80211: Set low initial
> rate in rc80211_simple".
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
>
> --- wireless-dev.orig/net/mac80211/rc80211_simple.c 2007-06-11 08:08:55.301879260 +0200
> +++ wireless-dev/net/mac80211/rc80211_simple.c 2007-06-11 08:09:06.791879260 +0200
> @@ -289,9 +289,10 @@ static void rate_control_simple_rate_ini
> * as a workaround, */
> for (i = 0; i < mode->num_rates; i++) {
> if ((sta->supp_rates & BIT(i)) &&
> - (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED))
> + (mode->rates[i].flags & IEEE80211_RATE_SUPPORTED)) {
> sta->txrate = i;
> break;
> + }
> }
> }
Thanks for this one - it is what I intended all along as indicated by the indentation. Now I
understand Michael Wu's comments regarding the loop.
Larry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-06-11 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-11 6:10 [PATCH] fix oversight in "mac80211: Set low initial rate in rc80211_simple" Johannes Berg
2007-06-11 16:22 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).