From: Patrick McHardy <kaber@trash.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Michael Wu <flamingice@sourmilk.net>, Jiri Benc <jbenc@suse.cz>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH RFC] mac80211: Make stop_queues() usable
Date: Tue, 03 Jul 2007 14:31:31 +0200 [thread overview]
Message-ID: <468A41A3.1020903@trash.net> (raw)
In-Reply-To: <200707031039.56710.mb@bu3sch.de>
Michael Buesch wrote:
> On Tuesday 03 July 2007 06:09:19 Michael Wu wrote:
>
>>On Monday 02 July 2007 13:35, Michael Buesch wrote:
>>
>>>+ netif_tx_lock_bh(mdev);
>>> for (i = 0; i < hw->queues; i++)
>>> ieee80211_stop_queue(hw, i);
>>>+ netif_tx_unlock_bh(mdev);
>>
>>Well, looks like this will break stopping all tx queues from the tx handler by
>>deadlocking. It may be useless for bcm43xx to call ieee80211_stop_queue, but
>>there are other drivers which rely on it.
The wireless multiqueue handling should be replaced by the generic
implementation in net-2.6.23 (using prio, seperating out the wme
classifier and killing the broken scheduler). You don't need to
stop individual subqueues for a full shutdown with that implementation,
you can just stop the global queue. Not sure if that really helps for
this case though since I didn't look to deep into this code.
next prev parent reply other threads:[~2007-07-03 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 20:35 [PATCH RFC] mac80211: Make stop_queues() usable Michael Buesch
2007-07-03 4:09 ` Michael Wu
2007-07-03 8:39 ` Michael Buesch
2007-07-03 12:31 ` Patrick McHardy [this message]
2007-07-03 12:39 ` Michael Buesch
2007-07-03 12:56 ` Patrick McHardy
2007-07-03 17:15 ` Michael Wu
2007-07-03 17:36 ` Michael Buesch
2007-07-03 17:41 ` Michael Wu
2007-07-03 17:47 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468A41A3.1020903@trash.net \
--to=kaber@trash.net \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).