[PATCH] eeprom_93cx6: shorten pulse timing to match spec (bis)

[PATCH] eeprom_93cx6: shorten pulse timing to match spec (bis)

[Francois Romieu]

Based on an original idea by John W. Linville.

It is the missing part of 42d45ccd60636c28e35c2016f091783bc14ad99c

Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
---
 drivers/misc/eeprom_93cx6.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/misc/eeprom_93cx6.c b/drivers/misc/eeprom_93cx6.c
index ac515b0..ea55654 100644
--- a/drivers/misc/eeprom_93cx6.c
+++ b/drivers/misc/eeprom_93cx6.c
@@ -55,10 +55,10 @@ static inline void eeprom_93cx6_pulse_low(struct eeprom_93cx6 *eeprom)
 
 	/*
 	 * Add a short delay for the pulse to work.
-	 * According to the specifications the minimal time
-	 * should be 450ns so a 1us delay is sufficient.
+	 * According to the specifications the "maximum minimum"
+	 * time should be 450ns.
 	 */
-	udelay(1);
+	ndelay(450);
 }
 
 static void eeprom_93cx6_startup(struct eeprom_93cx6 *eeprom)
-- 
1.5.2.1

Re: [PATCH] eeprom_93cx6: shorten pulse timing to match spec (bis)

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

On Wed, 2007-07-04 at 00:31 +0200, Francois Romieu wrote:
> Based on an original idea by John W. Linville.
> 
> It is the missing part of 42d45ccd60636c28e35c2016f091783bc14ad99c
                            ^
I can't find that commit in the current wireless-dev tree, can you
provide a correct reference or more explanation? Then again the patch
itself is short enough and I don't understand the need for the reference
at all.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] eeprom_93cx6: shorten pulse timing to match spec (bis)

[Francois Romieu]

Johannes Berg <johannes@sipsolutions.net> :
> On Wed, 2007-07-04 at 00:31 +0200, Francois Romieu wrote:
[...]
> > It is the missing part of 42d45ccd60636c28e35c2016f091783bc14ad99c
>                             ^
> I can't find that commit in the current wireless-dev tree, can you
> provide a correct reference or more explanation?

42d45ccd60636c28e35c2016f091783bc14ad99c is in Jeff's #upstream.

> Then again the patch itself is short enough and I don't understand
> the need for the reference at all.

I do not understand the need to discuss a simple patch either. :o)

-- 
Ueimor

Re: [PATCH] eeprom_93cx6: shorten pulse timing to match spec (bis)

[Jeff Garzik]

Francois Romieu wrote:
> Based on an original idea by John W. Linville.
> 
> It is the missing part of 42d45ccd60636c28e35c2016f091783bc14ad99c
> 
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
> ---
>  drivers/misc/eeprom_93cx6.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

applied