* [PATCH] softmac: Fix ESSID problem
@ 2007-07-10 1:37 Larry Finger
0 siblings, 0 replies; 3+ messages in thread
From: Larry Finger @ 2007-07-10 1:37 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
From: Jean Tourrilhes <jt@hpl.hp.com>
Victor Porton reported that the SoftMAC layer had random problem when setting the ESSID :
http://bugzilla.kernel.org/show_bug.cgi?id=8686 After investigation, it turned out to be
worse, the SoftMAC layer is left in an inconsistent state. The fix is pretty trivial.
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
Acked-by: Michael Buesch <mb@bu3sch.df>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
---
ieee80211softmac_assoc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
===================================================================
--- linux-2.6.orig/net/ieee80211/softmac/ieee80211softmac_assoc.c
+++ linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
@@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
*/
dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED, ieee80211softmac_assoc_notify_scan, NULL);
- if (ieee80211softmac_start_scan(mac))
+ if (ieee80211softmac_start_scan(mac)) {
dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
+ mac->associnfo.associating = 0;
+ mac->associnfo.associated = 0;
+ }
goto out;
} else {
mac->associnfo.associating = 0;
----
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] softmac: Fix ESSID problem
@ 2007-07-17 15:46 Larry Finger
2007-07-17 17:57 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2007-07-17 15:46 UTC (permalink / raw)
To: stable; +Cc: linux-wireless
From: Jean Tourrilhes <jt@hpl.hp.com>
Victor Porton reported that the SoftMAC layer had random problem when setting the ESSID :
http://bugzilla.kernel.org/show_bug.cgi?id=8686 After investigation, it turned out to be
worse, the SoftMAC layer is left in an inconsistent state. The fix is pretty trivial.
Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
Acked-by: Michael Buesch <mb@bu3sch.df>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
---
This patch is now in Linus's tree and should now be added to 2.6.22.Y.
Larry
ieee80211softmac_assoc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
Index: linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
===================================================================
--- linux-2.6.orig/net/ieee80211/softmac/ieee80211softmac_assoc.c
+++ linux-2.6/net/ieee80211/softmac/ieee80211softmac_assoc.c
@@ -271,8 +271,11 @@ ieee80211softmac_assoc_work(struct work_
*/
dprintk(KERN_INFO PFX "Associate: Scanning for networks first.\n");
ieee80211softmac_notify(mac->dev, IEEE80211SOFTMAC_EVENT_SCAN_FINISHED,
ieee80211softmac_assoc_notify_scan, NULL);
- if (ieee80211softmac_start_scan(mac))
+ if (ieee80211softmac_start_scan(mac)) {
dprintk(KERN_INFO PFX "Associate: failed to initiate scan. Is device up?\n");
+ mac->associnfo.associating = 0;
+ mac->associnfo.associated = 0;
+ }
goto out;
} else {
mac->associnfo.associating = 0;
----
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] softmac: Fix ESSID problem
2007-07-17 15:46 [PATCH] softmac: Fix ESSID problem Larry Finger
@ 2007-07-17 17:57 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2007-07-17 17:57 UTC (permalink / raw)
To: Larry Finger; +Cc: stable, linux-wireless
On Tue, Jul 17, 2007 at 10:46:33AM -0500, Larry Finger wrote:
> From: Jean Tourrilhes <jt@hpl.hp.com>
>
> Victor Porton reported that the SoftMAC layer had random problem when
> setting the ESSID :
> http://bugzilla.kernel.org/show_bug.cgi?id=8686 After investigation, it
> turned out to be
> worse, the SoftMAC layer is left in an inconsistent state. The fix is
> pretty trivial.
>
> Signed-off-by: Jean Tourrilhes <jt@hpl.hp.com>
> Acked-by: Michael Buesch <mb@bu3sch.df>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> This patch is now in Linus's tree and should now be added to 2.6.22.Y.
ACK for the stable guys.
John
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-17 18:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-17 15:46 [PATCH] softmac: Fix ESSID problem Larry Finger
2007-07-17 17:57 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2007-07-10 1:37 Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).