linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Green <andy@warmcat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Please pull patch-bomb for iwlwifi
Date: Wed, 25 Jul 2007 16:12:29 +0100	[thread overview]
Message-ID: <46A7685D.7050703@warmcat.com> (raw)
In-Reply-To: <200707251643.14926.hs4233@mail.mn-solutions.de>

Somebody in the thread at some point said:

> A cursory glance (I'm not in this mailing list) at 
> http://sourceforge.net/mailarchive/forum.php?forum_name=ipw3945-devel 
> shows that people indeed post patches there for review.
> 
> So, if you ask them to post each and every patch on 
> linux-wireless, then other projects should do the same. Some 
> projects (e.g. bcm43xx) mostly do cross-post. Is this the way 
> people should go?

Because there are different gatekeepers between the upstream project and
the kernel maybe it should get reposted.  What the ipw3945-ites accept
can be different from what the mac80211-its can accept and even the
lkml-ites can kick stuff at the end of the game according to their
differing requirements.

IMO as importantly patches need a visible lifecycle when they are
posted.  If a patch arrives on a list, either:

 - someone should comment or advise triggering debate and/or a retry,
which deprecates the earlier try;

 - the patch should be replied to with a NAK because it is unacceptable,
perhaps because it inherently violates something or perhaps because the
retry identified as needed from the debate never came;

 - the patch should be replied to with a NAK because after debate it is
agreed the intention of the patch can be done better by someone more
experienced with the code;

 - or the patch should be ACK'd, with some sign of where it is committed
now.

-Andy

  reply	other threads:[~2007-07-25 15:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-25  8:57 Please pull patch-bomb for iwlwifi Zhu Yi
2007-07-25  9:48 ` Andy Green
2007-07-25 14:23 ` Jeff Garzik
2007-07-25 14:43   ` Holger Schurig
2007-07-25 15:12     ` Andy Green [this message]
2007-07-25 15:15     ` Jeff Garzik
2007-07-25 15:35     ` Christoph Hellwig
2007-07-25 20:40     ` Dan Williams
2007-07-25 19:01   ` John W. Linville
2007-07-25 21:20     ` Jeff Garzik
2007-07-25 20:07 ` John W. Linville
2007-07-25 21:00   ` Tomas Winkler
2007-07-25 21:26     ` Jeff Garzik
2007-07-25 21:53       ` Tomas Winkler
2007-07-26  1:55   ` Zhu Yi
  -- strict thread matches above, loose matches on Subject: below --
2007-06-08 22:15 James Ketrenos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46A7685D.7050703@warmcat.com \
    --to=andy@warmcat.com \
    --cc=hs4233@mail.mn-solutions.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).