From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [RFC V3] bcm43xx-mac80211: Provide information to allow transmission rate decreases
Date: Thu, 02 Aug 2007 11:33:36 -0500 [thread overview]
Message-ID: <46B20760.5000406@lwfinger.net> (raw)
In-Reply-To: <200708021805.17004.mb@bu3sch.de>
Michael Buesch wrote:
> On Thursday 02 August 2007, Larry Finger wrote:
>> Michael,
>>
>> I couldn't find any long/short indication in the header, so I added a bool that
>> is set when the frame is sent.
>
> This is not going to work.
>
> But we can do this differently.
> You can do something like:
>
> if (!status->acked && !tx_control->noack)
> excessive_retries = 1;
>
> So we don't need to care about the retry count.
>
> Anyway. I don't know why we need excessive_retries _at_ _all_.
> The rc algorithm does already know if the frame succeed or failed
> anyway.
Yes, it does, but it only looks at the potential for reduction if excessive retries is set. Why?
Because it was coded that way! As I said earlier, I don't want to get involved there.
I'll try to implement it as above.
Larry
next prev parent reply other threads:[~2007-08-02 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-02 15:38 [RFC V3] bcm43xx-mac80211: Provide information to allow transmission rate decreases Larry Finger
2007-08-02 16:05 ` Michael Buesch
2007-08-02 16:33 ` Larry Finger [this message]
2007-08-02 19:44 ` Larry Finger
2007-08-02 19:59 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B20760.5000406@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).