From: Andy Green <andy@warmcat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ulrich Kunitz <kune@deine-taler.de>,
linux-wireless <linux-wireless@vger.kernel.org>,
Daniel Drake <dsd@gentoo.org>
Subject: Re: mac80211 driver interface semantics
Date: Fri, 03 Aug 2007 11:35:43 +0100 [thread overview]
Message-ID: <46B304FF.3000305@warmcat.com> (raw)
In-Reply-To: <1186137166.4647.34.camel@johannes.berg>
Somebody in the thread at some point said:
> On Fri, 2007-08-03 at 11:27 +0100, Andy Green wrote:
>
>> Inside that question, if you mark up skb->ip_summed with CHECKSUM_NONE,
>> include/linux/skbuff.h says this:
>>
>> /* A. Checksumming of received packets by device.
>> *
>> * NONE: device failed to checksum this packet.
>> * skb->csum is undefined.
>>
>> If we mark up the skb with FCS-broken packets with that, maybe it would
>> be compatible with the networking stack for this purpose.
>
> No, that's the IP checksum. It may or may not be broken if the FCS CRC
> fails.
Right, but since we marked up the skb "the integrity of the IP checksum
is unknown", if anything wants to use the packet it should re-check it
itself. Won't that do?
-Andy
next prev parent reply other threads:[~2007-08-03 10:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 0:30 mac80211 driver interface semantics Daniel Drake
2007-08-03 5:29 ` Ulrich Kunitz
2007-08-03 7:59 ` Andy Green
2007-08-03 9:54 ` Johannes Berg
2007-08-03 10:20 ` Joerg Mayer
2007-08-03 10:27 ` Andy Green
2007-08-03 10:32 ` Johannes Berg
2007-08-03 10:35 ` Andy Green [this message]
2007-08-03 10:41 ` Johannes Berg
2007-08-03 10:49 ` Andy Green
2007-08-06 6:44 ` Johannes Berg
2007-08-06 8:25 ` Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B304FF.3000305@warmcat.com \
--to=andy@warmcat.com \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).