From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Ivo van Doorn <ivdoorn@gmail.com>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH V3] mac80211: Turn off meaningless TKIP message when software WEP encryption is used
Date: Mon, 13 Aug 2007 19:24:21 -0500 [thread overview]
Message-ID: <46C0F635.9040300@lwfinger.net> (raw)
In-Reply-To: <200708131658.27758.flamingice@sourmilk.net>
Michael Wu wrote:
> On Monday 13 August 2007 16:13, Larry Finger wrote:
>> Yes, this empirical behavior does not seem to match one's intuition on what
>> the flag should do.
>>
> The flag means the hardware does the rc4 but doesn't bother to deal with the
> IV/ICV. If you're going do software encryption, there's no reason to bother
> with that flag, as that says your hardware supports and does rc4 in hardware.
That is fair enough, but why does that flag ever make any difference when the user has not provided
a set_key callback. My interpretation of the code was that this was one means of indicating that we
were never going to do any hardware encryption
It would be very helpful to driver writers if the comments in include/net/mac80211.h we improved.
This flag has none, but I don't think it is that obvious.
Larry
next prev parent reply other threads:[~2007-08-14 0:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 22:13 [PATCH V3] mac80211: Turn off meaningless TKIP message when software WEP encryption is used Larry Finger
2007-08-13 22:54 ` Ivo van Doorn
2007-08-13 23:13 ` Larry Finger
2007-08-13 23:58 ` Michael Wu
2007-08-14 0:24 ` Larry Finger [this message]
2007-08-20 17:55 ` Ivo van Doorn
2007-08-21 10:17 ` Johannes Berg
2007-08-15 0:16 ` Johannes Berg
2007-08-15 13:16 ` Larry Finger
2007-08-15 13:30 ` Johannes Berg
2007-08-16 22:32 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C0F635.9040300@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=flamingice@sourmilk.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).