From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Broadcom Linux <bcm43xx-dev@lists.berlios.de>,
wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC] mac80211: fix software decryption with b43legacy
Date: Mon, 20 Aug 2007 12:36:27 -0500 [thread overview]
Message-ID: <46C9D11B.4020001@lwfinger.net> (raw)
In-Reply-To: <1187611793.6090.102.camel@johannes.berg>
Johannes Berg wrote:
> On Sat, 2007-08-18 at 15:13 -0500, Larry Finger wrote:
>
>> The rest of the call trace is available if needed. The crash occurred when ieee80211_key_free was
>> trying to unlock the mutex key_idx. I added printk's to dump the pointer to sdata at the point where
>> that mutex is initialized and where the key is freed. The mutex that errs was inited.
>
> Ho humm, yes, I'm dumb, patch below but I'll fold it into my key patch.
> Sorry about that, classic use-after-free condition here.
The patch fixed the crash. The reason for the "lost AP" is that WPA isn't working for b43legacy,
with or without your patches. It used to work and I have no idea why it fails now.
Thanks,
Larry
next prev parent reply other threads:[~2007-08-20 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 10:26 [RFC] mac80211: fix software decryption Johannes Berg
[not found] ` <46C5CC0D.2040609@lwfinger.net>
[not found] ` <1187384230.6090.7.camel@johannes.berg>
[not found] ` <46C612E8.4020604@lwfinger.net>
[not found] ` <1187387215.6090.13.camel@johannes.berg>
[not found] ` <46C64777.1000602@lwfinger.net>
[not found] ` <1187453173.6090.33.camel@johannes.berg>
2007-08-18 20:13 ` [RFC] mac80211: fix software decryption with b43legacy Larry Finger
2007-08-20 11:20 ` Johannes Berg
2007-08-20 12:09 ` Johannes Berg
2007-08-20 17:36 ` Larry Finger [this message]
2007-08-20 22:43 ` Ulrich Kunitz
2007-08-21 0:18 ` Larry Finger
2007-08-21 4:59 ` [RFC] mac80211: fix software decryption Larry Finger
2007-08-21 10:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46C9D11B.4020001@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).