From: Larry Finger <larry.finger@lwfinger.net>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Jiri Slaby <jirislaby@gmail.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals
Date: Tue, 28 Aug 2007 12:47:07 -0500 [thread overview]
Message-ID: <46D45F9B.2000000@lwfinger.net> (raw)
In-Reply-To: <1188322410.7837.113.camel@johannes.berg>
Johannes Berg wrote:
> On Tue, 2007-08-28 at 18:10 +0100, Christoph Hellwig wrote:
>> On Tue, Aug 28, 2007 at 11:58:52AM -0400, Jiri Slaby wrote:
>>> -ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o
>>> +ath5k-objs = ath5k_base.o ath5k_hw.o ath5k_regdom.o \
>>> + ath5k_hw_phy.o ath5k_hw_inivals.o
>> And while I'm at nitpicking :)
>>
>> ath5k_hw_phy.o should probably be ath5k_phy.o by conventions used by
>> most drivers and ath5k_hw_inivals.o mights aswell be something like
>> ath5k_init.o
>
> While we're at names... I personally much prefer a new directory ath5k
> and then ath5k/hw.c etc. but it seems I'm pretty alone in that. But here
> we already have at least four files now.
I agree with you. If a wireless driver takes more than one .c and one .h file, it belongs in its own
directory, and the file names stripped of any driver prefix. Not only are the file names simpler,
but Makefile and Kconfig in wireless benefits.
Larry
next prev parent reply other threads:[~2007-08-28 17:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 15:58 [PATCH 1/5] Net: ath5k, split hw into hw, phy and initvals Jiri Slaby
2007-08-28 16:22 ` Johannes Berg
2007-08-28 17:08 ` Christoph Hellwig
2007-08-28 17:10 ` Christoph Hellwig
2007-08-28 17:33 ` Johannes Berg
2007-08-28 17:47 ` Larry Finger [this message]
2007-08-28 21:50 ` Luis R. Rodriguez
2007-08-30 1:50 ` Nick Kossifidis
2007-08-30 12:38 ` John W. Linville
2007-09-01 3:12 ` Nick Kossifidis
[not found] ` <7515194658758617@pripojeni.net>
2007-08-28 17:11 ` [PATCH 4/5] Net: ath5k, license is GPLv2 Christoph Hellwig
2007-08-28 20:11 ` Luis R. Rodriguez
2007-08-29 17:29 ` Valdis.Kletnieks
2007-08-29 18:01 ` Jon Smirl
2007-08-29 18:28 ` Alan Cox
2007-08-29 19:33 ` Jon Smirl
2007-08-29 19:37 ` Michael Buesch
2007-08-30 8:26 ` Jarek Poplawski
2007-08-30 8:32 ` Jarek Poplawski
2007-08-29 19:45 ` Alan Cox
2007-08-30 13:45 ` Jarek Poplawski
2007-08-30 13:02 ` David Newall
2007-08-29 9:59 ` Johannes Berg
2007-08-29 10:35 ` Jiri Slaby
2007-08-29 13:13 ` Xavier Bestel
2007-08-30 11:59 ` Johannes Berg
[not found] ` <280951420471148977@pripojeni.net>
2007-08-28 17:13 ` [PATCH 5/5] Net: ath5k, kconfig changes Christoph Hellwig
2007-08-30 1:38 ` Nick Kossifidis
2007-08-30 12:35 ` Christoph Hellwig
2007-08-30 12:36 ` John W. Linville
2007-08-30 22:18 ` Nick Kossifidis
2007-09-01 5:58 ` Nick Kossifidis
2007-08-31 11:58 ` Dan Williams
2007-08-31 13:30 ` Jeff Garzik
2007-08-31 14:32 ` Dan Williams
[not found] ` <2440910618305782004@pripojeni.net>
2007-08-30 12:40 ` [PATCH 3/5] Net: ath5k, use int as retval John W. Linville
2007-09-01 20:08 ` Jiri Slaby
2007-09-02 15:55 ` Nick Kossifidis
2007-09-03 6:34 ` Jiri Slaby
2007-09-03 13:37 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D45F9B.2000000@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=hch@infradead.org \
--cc=jirislaby@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).