From: Daniel Drake <dsd@gentoo.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 2/2] mac80211: revamp interface and filter configuration
Date: Sun, 02 Sep 2007 22:07:55 -0400 [thread overview]
Message-ID: <46DB6C7B.3020001@gentoo.org> (raw)
In-Reply-To: <20070821161942.938977000@sipsolutions.net>
Johannes Berg wrote:
> + /*
> + * Configure the device's RX filter.
[...]
> + * Must be atomic due to running under the tx lock.
This is slightly freaky for zd1211rw and probably other USB drivers. In
most cases we can't act upon any of those filter flag changes in atomic
context.
We could defer work like we do for multicast lists, but then the driver
would be lying in that it would return from configure_filter saying that
it has honoured some flags without actually having done so (yet).
Will that be a problem? I'm thinking maybe not, since the flags only
affect RX and we can't determine which frames will be in the air at any
time. [as opposed to such atomicity problems that relate to TX, we can
just disable TX until the work has completed]
> + * This callback is must be implemented.
> + */
Typo.
Daniel
next prev parent reply other threads:[~2007-09-03 2:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 16:18 [RFC 0/2] the filter stuff again Johannes Berg
2007-08-21 16:18 ` [RFC 1/2] mac80211: allow drivers to indicate failed FCS/PLCP checksum Johannes Berg
2007-08-21 21:07 ` Ivo van Doorn
2007-08-22 9:22 ` Johannes Berg
2007-08-22 19:11 ` Ivo van Doorn
2007-08-23 14:13 ` Johannes Berg
2007-08-21 16:18 ` [RFC 2/2] mac80211: revamp interface and filter configuration Johannes Berg
2007-08-21 21:14 ` Ivo van Doorn
2007-08-22 9:23 ` Johannes Berg
2007-09-03 2:07 ` Daniel Drake [this message]
2007-09-03 8:36 ` Johannes Berg
2007-09-03 9:29 ` Johannes Berg
2007-09-03 10:57 ` Johannes Berg
2007-09-05 5:16 ` Ulrich Kunitz
2007-09-05 11:23 ` Johannes Berg
2007-09-05 14:16 ` Michael Buesch
2007-09-05 14:21 ` Johannes Berg
2007-09-05 14:23 ` Michael Wu
2007-09-05 14:33 ` Johannes Berg
2007-09-03 13:32 ` Johannes Berg
-- strict thread matches above, loose matches on Subject: below --
2007-08-15 15:25 [RFC 0/2] device configuration changes Johannes Berg
2007-08-15 15:25 ` [RFC 2/2] mac80211: revamp interface and filter configuration Johannes Berg
2007-08-16 12:41 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DB6C7B.3020001@gentoo.org \
--to=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).