From: Dave <kilroyd@googlemail.com>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 00/05] orinoco: Agere/Lucent firmware download
Date: Fri, 14 Sep 2007 19:48:00 +0100 [thread overview]
Message-ID: <46EAD760.9020102@gmail.com> (raw)
In-Reply-To: <46EACAA5.2050706@gmail.com>
Dave wrote:
> Pavel Roskin wrote:
>> On Wed, 2007-09-12 at 22:09 +0100, Dave wrote:
>>> Implements firmware download to RAM for Lucent-Agere firmware.
>>> Firmware download is a requirement to implement WPA on these cards.
>>
>> Please use sparse to check endianess and other issues. You can use this
>> command once sparse is in PATH:
>>
>> make C=2 CF="-Wall -D__CHECK_ENDIAN__"
Either that was painless, or I did it wrong. Using sparse 3.0 the only warnings were in orinoco.c, related to the use of ARRAY_SIZE. Errors are false positives.
$ make O=../build C=2 CF="-Wall -D__CHECK_ENDIAN__" > ../sparse.log 2>&1
<snip>
CHECK /usr/src/linux-current/linux-2.6/drivers/net/irda/sir_dongle.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:1391:27: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:2542:35: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:2771:24: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:2773:18: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:3118:19: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:3123:29: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:3357:18: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:3393:2: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:3421:20: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:3426:13: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:4007:38: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:4278:18: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:4279:17: error: cannot size expression
/usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco.c:4280:22: error: cannot size expression
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/hermes.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/hermes_dld.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco_cs.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco_plx.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco_pci.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco_tmd.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/orinoco_nortel.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/spectrum_cs.c
CHECK /usr/src/linux-current/linux-2.6/drivers/net/wireless/zd1201.c
<snip>
Regards,
Dave.
next prev parent reply other threads:[~2007-09-14 18:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 21:09 [PATCH 00/05] orinoco: Agere/Lucent firmware download Dave
2007-09-14 5:05 ` Pavel Roskin
2007-09-14 17:53 ` Dave
2007-09-14 18:48 ` Dave [this message]
2007-09-14 19:06 ` Johannes Berg
2007-09-14 21:01 ` Dave
2007-09-14 21:13 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EAD760.9020102@gmail.com \
--to=kilroyd@googlemail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).