From: Larry Finger <larry.finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] b43legacy: Fix machine check errors for PPC architecture with BCM4306/2
Date: Sat, 15 Sep 2007 16:01:56 -0500 [thread overview]
Message-ID: <46EC4844.1060003@lwfinger.net> (raw)
In-Reply-To: <200709152147.57431.mb@bu3sch.de>
Michael Buesch wrote:
> With your patch you remove the "gmode" semantics, so you could
> as well remove the whole variable and always assume it's set.
> But I don't recommend to go that way. I'd suggest you find the
> place in the code where phy->gmode is not set but it should be.
> _that_ is the place where the real bug is.
>
> Just want to make sure you understand the consequences of your patch.
> You remove a feature with that.
> If that feature is really needed in legacy; that is another question.
> It's needed if you want to drive APHY devices.
All of the devices that b43legacy drives have either a BPHY or a GPHY. The current logic always sets
gmode and that feature is meaningless. Anyone overriding the rules that select this driver in order
to operate with an APHY device will hit a BUG_ON in wireless_core_attach.
I have generated and tested a patch that changes back to the old 'connected' variable. That will
avoid the semantics argument and match the V3 specs.
Larry
next prev parent reply other threads:[~2007-09-15 21:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 17:39 [PATCH] b43legacy: Fix machine check errors for PPC architecture with BCM4306/2 Larry Finger
2007-09-15 17:48 ` Michael Buesch
2007-09-15 18:07 ` Larry Finger
2007-09-15 18:10 ` Michael Buesch
2007-09-15 19:12 ` Larry Finger
2007-09-15 19:47 ` Michael Buesch
2007-09-15 21:01 ` Larry Finger [this message]
2007-09-15 21:58 ` Michael Buesch
2007-09-15 23:26 ` Larry Finger
2007-09-15 23:58 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EC4844.1060003@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).