From: Jeff Garzik <jeff@garzik.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only
Date: Mon, 17 Sep 2007 16:59:07 -0400 [thread overview]
Message-ID: <46EEEA9B.70407@garzik.org> (raw)
In-Reply-To: <46EEE735.5050306@gmail.com>
Jiri Slaby wrote:
> NACK, this is wrong. iomap returns platform dependant return value, which may or
Incorrect. readl() and writel() work just fine on all existing
platforms where Atheros may be used.
If you want pci_iomap() usage removed as well, that's a fair request.
Jeff
next prev parent reply other threads:[~2007-09-17 20:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 20:34 [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only Luis R. Rodriguez
2007-09-17 20:44 ` Jiri Slaby
2007-09-17 20:59 ` Jeff Garzik [this message]
2007-09-17 21:44 ` Jiri Slaby
2007-09-18 19:03 ` Luis R. Rodriguez
2007-09-18 19:12 ` Luis R. Rodriguez
2007-09-18 22:18 ` Benjamin Herrenschmidt
2007-09-18 22:44 ` Jeff Garzik
2007-09-17 20:59 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46EEEA9B.70407@garzik.org \
--to=jeff@garzik.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).