From: Jeff Garzik <jeff@garzik.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only
Date: Tue, 18 Sep 2007 18:44:36 -0400 [thread overview]
Message-ID: <46F054D4.5090006@garzik.org> (raw)
In-Reply-To: <1190153934.6403.123.camel@localhost.localdomain>
Benjamin Herrenschmidt wrote:
> To be more precise, a platform has every right to return some kind of
> "token" from ioport_map/pci_iomap that encodes the type of address, and
> that is -different- from what a normal ioremap does. In which case, you
> will -not- be able to use readb/writeb & cie on such a token.
>
> The fact that current implementations seem to return something for MMIO
> that is equivalent to what ioremap returns is an accident and cannot be
> relied upon.
Fair enough. It's easy enough to change ath5k to using ioremap (or
pci_ioremap).
Jeff
next prev parent reply other threads:[~2007-09-18 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-17 20:34 [PATCH] revert ath5k ioread32()/iowrite32() usage - use readl()/writel(), we're MMIO-only Luis R. Rodriguez
2007-09-17 20:44 ` Jiri Slaby
2007-09-17 20:59 ` Jeff Garzik
2007-09-17 21:44 ` Jiri Slaby
2007-09-18 19:03 ` Luis R. Rodriguez
2007-09-18 19:12 ` Luis R. Rodriguez
2007-09-18 22:18 ` Benjamin Herrenschmidt
2007-09-18 22:44 ` Jeff Garzik [this message]
2007-09-17 20:59 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F054D4.5090006@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).