Linux wireless drivers development
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: "niko3x@proton.me" <niko3x@proton.me>,
	Jes Sorensen <Jes.Sorensen@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next 3/3] wifi: rtl8xxxu: honour the bandwidth of injected frames on gen1 chips
Date: Sun, 22 Nov 2026 02:05:30 +0000	[thread overview]
Message-ID: <46a467eddd9e48e0b3ae93391608e857@realtek.com> (raw)
In-Reply-To: <20261120-b4-inject-v1-3-1e1693af0c6b@proton.me>

Ahmet Zeren via B4 Relay <devnull+niko3x.proton.me@kernel.org> wrote:
> From: Ahmet Zeren <niko3x@proton.me>
> 
> Injected frames are always sent at 20 MHz, even when they ask for 40 MHz
> on a 40 MHz channel, because only QoS data frames get the 40 MHz bits in
> the TX descriptor.
> 
> Set them for injected frames with IEEE80211_TX_RC_40_MHZ_WIDTH.
> 
> Tested on RTL8192CU (0bda:8178) on channel 6 HT40+ and HT40-, received
> by a second radio sniffing at 40 MHz: MCS 0 and 7 requested at 40 MHz
> arrive at 40 MHz (without this patch: 20 MHz), requested at 20 MHz they
> stay at 20 MHz.
> 
> Signed-off-by: Ahmet Zeren <niko3x@proton.me>

A small nit. Otherwise looks good to me

Acked-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtl8xxxu/core.c | 23 ++++++++++++++---------
>  1 file changed, 14 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> index b159d9b64c..2eef4585a8 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/core.c
> @@ -5281,7 +5281,7 @@ rtl8xxxu_fill_txdesc_v1(struct ieee80211_hw *hw, struct ieee80211_hdr *hdr,
>         u32 rate = 0;
>         u16 seq_number;
>         int retries;
> -       bool inject;
> +       bool inject, bw40;

To be in reverse X'mas order, declare it in another line.

> 
>         inject = rtl8xxxu_tx_rate_inject(tx_info, &rate, &sgi);
>         retries = rtl8xxxu_tx_retry_inject(tx_info);

[...]

pw-bot: cr



      reply	other threads:[~2026-11-22  2:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 22:09 [PATCH rtw-next 0/3] wifi: rtl8xxxu: honour rate, retries and bandwidth of injected frames Ahmet Zeren via B4 Relay
2026-11-19 22:09 ` [PATCH rtw-next 1/3] wifi: rtl8xxxu: honour the rate of injected frames on gen1 chips Ahmet Zeren via B4 Relay
2026-11-22  1:51   ` Ping-Ke Shih
2026-11-19 22:09 ` [PATCH rtw-next 2/3] wifi: rtl8xxxu: honour the retry count " Ahmet Zeren via B4 Relay
2026-11-22  2:00   ` Ping-Ke Shih
2026-11-19 22:09 ` [PATCH rtw-next 3/3] wifi: rtl8xxxu: honour the bandwidth " Ahmet Zeren via B4 Relay
2026-11-22  2:05   ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a467eddd9e48e0b3ae93391608e857@realtek.com \
    --to=pkshih@realtek.com \
    --cc=Jes.Sorensen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=niko3x@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox