* [PATCH] z1211: Make the LEDs warning debug-only
@ 2007-09-29 10:23 Michael Buesch
2007-10-02 16:34 ` Daniel Drake
0 siblings, 1 reply; 2+ messages in thread
From: Michael Buesch @ 2007-09-29 10:23 UTC (permalink / raw)
To: Ulrich Kunitz, Daniel Drake, John Linville; +Cc: linux-wireless
This warning triggers now and then with an -ETIMEDOUT error.
Though the LEDs work fine.
Make this warning debug-only, as nobody is really interested
in a LED failure that happens only now and then.
If the LEDs don't work, one can easily enable debugging to see
what's going on.
This reduces dmesg spamming.
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/z1211/zd_mac.c 2007-09-25 22:51:28.000000000 +0200
+++ wireless-2.6/drivers/net/wireless/z1211/zd_mac.c 2007-09-29 12:19:54.000000000 +0200
@@ -922,7 +922,7 @@ static void link_led_handler(struct work
r = zd_chip_control_leds(chip,
is_associated ? LED_ASSOCIATED : LED_SCANNING);
if (r)
- dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
+ dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
LINK_LED_WORK_DELAY);
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] z1211: Make the LEDs warning debug-only
2007-09-29 10:23 [PATCH] z1211: Make the LEDs warning debug-only Michael Buesch
@ 2007-10-02 16:34 ` Daniel Drake
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Drake @ 2007-10-02 16:34 UTC (permalink / raw)
To: John Linville; +Cc: Michael Buesch, Ulrich Kunitz, linux-wireless
Michael Buesch wrote:
> This warning triggers now and then with an -ETIMEDOUT error.
> Though the LEDs work fine.
> Make this warning debug-only, as nobody is really interested
> in a LED failure that happens only now and then.
> If the LEDs don't work, one can easily enable debugging to see
> what's going on.
> This reduces dmesg spamming.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Daniel Drake <dsd@gentoo.org>
>
> Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/z1211/zd_mac.c 2007-09-25 22:51:28.000000000 +0200
> +++ wireless-2.6/drivers/net/wireless/z1211/zd_mac.c 2007-09-29 12:19:54.000000000 +0200
> @@ -922,7 +922,7 @@ static void link_led_handler(struct work
> r = zd_chip_control_leds(chip,
> is_associated ? LED_ASSOCIATED : LED_SCANNING);
> if (r)
> - dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
> + dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
>
> queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
> LINK_LED_WORK_DELAY);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-02 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-29 10:23 [PATCH] z1211: Make the LEDs warning debug-only Michael Buesch
2007-10-02 16:34 ` Daniel Drake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).